[ovs-dev,v2] doc: Remove experimental tag for SMC cache.
diff mbox series

Message ID 1563363537-140487-1-git-send-email-yipeng1.wang@intel.com
State Accepted
Headers show
Series
  • [ovs-dev,v2] doc: Remove experimental tag for SMC cache.
Related show

Commit Message

Wang, Yipeng1 July 17, 2019, 11:38 a.m. UTC
SMC cache was introduced in 2.10 with experimental tag.
SMC cache is a layer of software cache located after EMC
cache. The purpose is to improve the performance of use
cases that many flows missing the EMC cache.

One can enable SMC cache using smc-enable=true option.

Signed-off-by: Yipeng Wang <yipeng1.wang@intel.com>
---
 Documentation/topics/dpdk/bridge.rst | 6 +++---
 NEWS                                 | 1 +
 2 files changed, 4 insertions(+), 3 deletions(-)

Comments

Stokes, Ian July 17, 2019, 8:25 p.m. UTC | #1
On 7/17/2019 12:38 PM, Yipeng Wang wrote:
> SMC cache was introduced in 2.10 with experimental tag.
> SMC cache is a layer of software cache located after EMC
> cache. The purpose is to improve the performance of use
> cases that many flows missing the EMC cache.
> 
> One can enable SMC cache using smc-enable=true option.
> 
> Signed-off-by: Yipeng Wang <yipeng1.wang@intel.com>

Thanks for the v2 Yipeng.

@Ilya, I think this addresses the issues you raised. If this is good 
with you I can add your ack and push tomorrow?

Regards
Ian

> ---
>   Documentation/topics/dpdk/bridge.rst | 6 +++---
>   NEWS                                 | 1 +
>   2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/topics/dpdk/bridge.rst b/Documentation/topics/dpdk/bridge.rst
> index a3ed926..4ca79a4 100644
> --- a/Documentation/topics/dpdk/bridge.rst
> +++ b/Documentation/topics/dpdk/bridge.rst
> @@ -117,15 +117,15 @@ It is also possible to enable/disable EMC on per-port basis using::
>   For more information on the EMC refer to :doc:`/intro/install/dpdk` .
>   
>   
> -SMC cache (experimental)
> --------------------------
> +SMC cache
> +---------
>   
>   SMC cache or signature match cache is a new cache level after EMC cache.
>   The difference between SMC and EMC is SMC only stores a signature of a flow
>   thus it is much more memory efficient. With same memory space, EMC can store 8k
>   flows while SMC can store 1M flows. When traffic flow count is much larger than
>   EMC size, it is generally beneficial to turn off EMC and turn on SMC. It is
> -currently turned off by default and an experimental feature.
> +currently turned off by default.
>   
>   To turn on SMC::
>   
> diff --git a/NEWS b/NEWS
> index 806e3c8..feae994 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -34,6 +34,7 @@ Post-v2.11.0
>        * 'ovs-appctl exit' now implies cleanup of non-internal ports in userspace
>          datapath regardless of '--cleanup' option. Use '--cleanup' to remove
>          internal ports too.
> +     * Removed experimental tag for SMC cache.
>      - OVSDB:
>        * OVSDB clients can now resynchronize with clustered servers much more
>          quickly after a brief disconnection, saving bandwidth and CPU time.
>
Ilya Maximets July 18, 2019, 11:56 a.m. UTC | #2
On 17.07.2019 23:25, Ian Stokes wrote:
> On 7/17/2019 12:38 PM, Yipeng Wang wrote:
>> SMC cache was introduced in 2.10 with experimental tag.
>> SMC cache is a layer of software cache located after EMC
>> cache. The purpose is to improve the performance of use
>> cases that many flows missing the EMC cache.
>>
>> One can enable SMC cache using smc-enable=true option.
>>
>> Signed-off-by: Yipeng Wang <yipeng1.wang@intel.com>
> 
> Thanks for the v2 Yipeng.
> 
> @Ilya, I think this addresses the issues you raised. If this is good with you I can add your ack and push tomorrow?

Sure. LGTM.

Best regards, Ilya Maximets.

> 
> Regards
> Ian
> 
>> ---
>>   Documentation/topics/dpdk/bridge.rst | 6 +++---
>>   NEWS                                 | 1 +
>>   2 files changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/topics/dpdk/bridge.rst b/Documentation/topics/dpdk/bridge.rst
>> index a3ed926..4ca79a4 100644
>> --- a/Documentation/topics/dpdk/bridge.rst
>> +++ b/Documentation/topics/dpdk/bridge.rst
>> @@ -117,15 +117,15 @@ It is also possible to enable/disable EMC on per-port basis using::
>>   For more information on the EMC refer to :doc:`/intro/install/dpdk` .
>>     -SMC cache (experimental)
>> --------------------------
>> +SMC cache
>> +---------
>>     SMC cache or signature match cache is a new cache level after EMC cache.
>>   The difference between SMC and EMC is SMC only stores a signature of a flow
>>   thus it is much more memory efficient. With same memory space, EMC can store 8k
>>   flows while SMC can store 1M flows. When traffic flow count is much larger than
>>   EMC size, it is generally beneficial to turn off EMC and turn on SMC. It is
>> -currently turned off by default and an experimental feature.
>> +currently turned off by default.
>>     To turn on SMC::
>>   diff --git a/NEWS b/NEWS
>> index 806e3c8..feae994 100644
>> --- a/NEWS
>> +++ b/NEWS
>> @@ -34,6 +34,7 @@ Post-v2.11.0
>>        * 'ovs-appctl exit' now implies cleanup of non-internal ports in userspace
>>          datapath regardless of '--cleanup' option. Use '--cleanup' to remove
>>          internal ports too.
>> +     * Removed experimental tag for SMC cache.
>>      - OVSDB:
>>        * OVSDB clients can now resynchronize with clustered servers much more
>>          quickly after a brief disconnection, saving bandwidth and CPU time.
>>
> 
> 
>
Stokes, Ian July 18, 2019, 12:54 p.m. UTC | #3
On 7/18/2019 12:56 PM, Ilya Maximets wrote:
> On 17.07.2019 23:25, Ian Stokes wrote:
>> On 7/17/2019 12:38 PM, Yipeng Wang wrote:
>>> SMC cache was introduced in 2.10 with experimental tag.
>>> SMC cache is a layer of software cache located after EMC
>>> cache. The purpose is to improve the performance of use
>>> cases that many flows missing the EMC cache.
>>>
>>> One can enable SMC cache using smc-enable=true option.
>>>
>>> Signed-off-by: Yipeng Wang <yipeng1.wang@intel.com>
>>
>> Thanks for the v2 Yipeng.
>>
>> @Ilya, I think this addresses the issues you raised. If this is good with you I can add your ack and push tomorrow?
> 
> Sure. LGTM.
> 
> Best regards, Ilya Maximets.
> 

Thanks all, have pushed this to master.

Regards
Ian

Patch
diff mbox series

diff --git a/Documentation/topics/dpdk/bridge.rst b/Documentation/topics/dpdk/bridge.rst
index a3ed926..4ca79a4 100644
--- a/Documentation/topics/dpdk/bridge.rst
+++ b/Documentation/topics/dpdk/bridge.rst
@@ -117,15 +117,15 @@  It is also possible to enable/disable EMC on per-port basis using::
 For more information on the EMC refer to :doc:`/intro/install/dpdk` .
 
 
-SMC cache (experimental)
--------------------------
+SMC cache
+---------
 
 SMC cache or signature match cache is a new cache level after EMC cache.
 The difference between SMC and EMC is SMC only stores a signature of a flow
 thus it is much more memory efficient. With same memory space, EMC can store 8k
 flows while SMC can store 1M flows. When traffic flow count is much larger than
 EMC size, it is generally beneficial to turn off EMC and turn on SMC. It is
-currently turned off by default and an experimental feature.
+currently turned off by default.
 
 To turn on SMC::
 
diff --git a/NEWS b/NEWS
index 806e3c8..feae994 100644
--- a/NEWS
+++ b/NEWS
@@ -34,6 +34,7 @@  Post-v2.11.0
      * 'ovs-appctl exit' now implies cleanup of non-internal ports in userspace
        datapath regardless of '--cleanup' option. Use '--cleanup' to remove
        internal ports too.
+     * Removed experimental tag for SMC cache.
    - OVSDB:
      * OVSDB clients can now resynchronize with clustered servers much more
        quickly after a brief disconnection, saving bandwidth and CPU time.