[U-Boot,4/4] arm: dts: Set custom names for cp110 master/slave MDIO buses
diff mbox series

Message ID 20190717151026.27994-5-alexandru.marginean@nxp.com
State Superseded
Delegated to: Joe Hershberger
Headers show
Series
  • Marvell MDIO driver and new MDIO name property
Related show

Commit Message

Alex Marginean July 17, 2019, 3:10 p.m. UTC
Implicitly Marvell MDIO driver uses DT node names for devices, but in this
case that is not unique.  Set MDIO device names for master/slave to
cpm/cps.

Signed-off-by: Alex Marginean <alexm.osslist@gmail.com>
---
 arch/arm/dts/armada-cp110-master.dtsi | 1 +
 arch/arm/dts/armada-cp110-slave.dtsi  | 1 +
 2 files changed, 2 insertions(+)

Comments

Joe Hershberger July 23, 2019, 12:29 a.m. UTC | #1
On Wed, Jul 17, 2019 at 10:12 AM Alex Marginean
<alexandru.marginean@nxp.com> wrote:
>
> Implicitly Marvell MDIO driver uses DT node names for devices, but in this
> case that is not unique.  Set MDIO device names for master/slave to
> cpm/cps.
>
> Signed-off-by: Alex Marginean <alexm.osslist@gmail.com>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Nevo Hed July 23, 2019, 3:17 p.m. UTC | #2
Sorry for the late input

The cp110s have an mdio and an xmdio so
Locally I have been naming them cpm-xmdio, cpm-mdio, cps-xmdio, cps-mdio

I knew the new field is coming but didn't catch that the 'dtsi's patch

On Mon, Jul 22, 2019 at 8:30 PM Joe Hershberger <joe.hershberger@ni.com> wrote:
>
> On Wed, Jul 17, 2019 at 10:12 AM Alex Marginean
> <alexandru.marginean@nxp.com> wrote:
> >
> > Implicitly Marvell MDIO driver uses DT node names for devices, but in this
> > case that is not unique.  Set MDIO device names for master/slave to
> > cpm/cps.
> >
> > Signed-off-by: Alex Marginean <alexm.osslist@gmail.com>
>
> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
Nevo Hed July 23, 2019, 5:03 p.m. UTC | #3
Sorry for the late input

The cp110s have an mdio and an xmdio so
Locally I have been naming them cpm-xmdio, cpm-mdio, cps-xmdio, cps-mdio

I knew the new field is coming but didn't catch that the 'dtsi's patch

[also apologies if you get this a second time]

On Mon, Jul 22, 2019 at 8:30 PM Joe Hershberger <joe.hershberger@ni.com> wrote:
>
> On Wed, Jul 17, 2019 at 10:12 AM Alex Marginean
> <alexandru.marginean@nxp.com> wrote:
> >
> > Implicitly Marvell MDIO driver uses DT node names for devices, but in this
> > case that is not unique.  Set MDIO device names for master/slave to
> > cpm/cps.
> >
> > Signed-off-by: Alex Marginean <alexm.osslist@gmail.com>
>
> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
Nevo Hed July 23, 2019, 5:22 p.m. UTC | #4
For context from upstream linux,
https://github.com/torvalds/linux/commit/f66b2aff46eaf0825dbe1560e28fcb845dd2a215

I was intending to submit the parallel change here once fully tested
end-end on our hardware,
but if not too late my proposal is to name the above nodes as
"cpm-mdio" & "cps-mdio"


On Tue, Jul 23, 2019 at 1:03 PM Nevo Hed <nhed+uboot@starry.com> wrote:
>
> Sorry for the late input
>
> The cp110s have an mdio and an xmdio so
> Locally I have been naming them cpm-xmdio, cpm-mdio, cps-xmdio, cps-mdio
>
> I knew the new field is coming but didn't catch that the 'dtsi's patch
>
> [also apologies if you get this a second time]
>
> On Mon, Jul 22, 2019 at 8:30 PM Joe Hershberger <joe.hershberger@ni.com> wrote:
> >
> > On Wed, Jul 17, 2019 at 10:12 AM Alex Marginean
> > <alexandru.marginean@nxp.com> wrote:
> > >
> > > Implicitly Marvell MDIO driver uses DT node names for devices, but in this
> > > case that is not unique.  Set MDIO device names for master/slave to
> > > cpm/cps.
> > >
> > > Signed-off-by: Alex Marginean <alexm.osslist@gmail.com>
> >
> > Acked-by: Joe Hershberger <joe.hershberger@ni.com>
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot@lists.denx.de
> > https://lists.denx.de/listinfo/u-boot
Alex Marginean July 24, 2019, 1:05 p.m. UTC | #5
On 7/23/2019 8:22 PM, Nevo Hed wrote:
> For context from upstream linux,
> https://github.com/torvalds/linux/commit/f66b2aff46eaf0825dbe1560e28fcb845dd2a215
> 
> I was intending to submit the parallel change here once fully tested
> end-end on our hardware,
> but if not too late my proposal is to name the above nodes as
> "cpm-mdio" & "cps-mdio"

I'm OK with "-mdio", I can send a v2.
Please node that I used a property called 'device-name' rather than
'mdio-name', I'm not sure if you want to pick that up too or not.

Thanks!
Alex

> 
> 
> On Tue, Jul 23, 2019 at 1:03 PM Nevo Hed <nhed+uboot@starry.com> wrote:
>>
>> Sorry for the late input
>>
>> The cp110s have an mdio and an xmdio so
>> Locally I have been naming them cpm-xmdio, cpm-mdio, cps-xmdio, cps-mdio
>>
>> I knew the new field is coming but didn't catch that the 'dtsi's patch
>>
>> [also apologies if you get this a second time]
>>
>> On Mon, Jul 22, 2019 at 8:30 PM Joe Hershberger <joe.hershberger@ni.com> wrote:
>>>
>>> On Wed, Jul 17, 2019 at 10:12 AM Alex Marginean
>>> <alexandru.marginean@nxp.com> wrote:
>>>>
>>>> Implicitly Marvell MDIO driver uses DT node names for devices, but in this
>>>> case that is not unique.  Set MDIO device names for master/slave to
>>>> cpm/cps.
>>>>
>>>> Signed-off-by: Alex Marginean <alexm.osslist@gmail.com>
>>>
>>> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
>>> _______________________________________________
>>> U-Boot mailing list
>>> U-Boot@lists.denx.de
>>> https://lists.denx.de/listinfo/u-boot
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
>
Joe Hershberger July 24, 2019, 6:57 p.m. UTC | #6
On Wed, Jul 24, 2019 at 8:06 AM Alex Marginean <alexm.osslist@gmail.com> wrote:
>
> On 7/23/2019 8:22 PM, Nevo Hed wrote:
> > For context from upstream linux,
> > https://github.com/torvalds/linux/commit/f66b2aff46eaf0825dbe1560e28fcb845dd2a215
> >
> > I was intending to submit the parallel change here once fully tested
> > end-end on our hardware,
> > but if not too late my proposal is to name the above nodes as
> > "cpm-mdio" & "cps-mdio"
>
> I'm OK with "-mdio", I can send a v2.
> Please node that I used a property called 'device-name' rather than
> 'mdio-name', I'm not sure if you want to pick that up too or not.

Let me know when this is settled and I'll take the series.

Thanks,
-Joe

> >
> >
> > On Tue, Jul 23, 2019 at 1:03 PM Nevo Hed <nhed+uboot@starry.com> wrote:
> >>
> >> Sorry for the late input
> >>
> >> The cp110s have an mdio and an xmdio so
> >> Locally I have been naming them cpm-xmdio, cpm-mdio, cps-xmdio, cps-mdio
> >>
> >> I knew the new field is coming but didn't catch that the 'dtsi's patch
> >>
> >> [also apologies if you get this a second time]
> >>
> >> On Mon, Jul 22, 2019 at 8:30 PM Joe Hershberger <joe.hershberger@ni.com> wrote:
> >>>
> >>> On Wed, Jul 17, 2019 at 10:12 AM Alex Marginean
> >>> <alexandru.marginean@nxp.com> wrote:
> >>>>
> >>>> Implicitly Marvell MDIO driver uses DT node names for devices, but in this
> >>>> case that is not unique.  Set MDIO device names for master/slave to
> >>>> cpm/cps.
> >>>>
> >>>> Signed-off-by: Alex Marginean <alexm.osslist@gmail.com>
> >>>
> >>> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
> >>> _______________________________________________
> >>> U-Boot mailing list
> >>> U-Boot@lists.denx.de
> >>> https://lists.denx.de/listinfo/u-boot
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot@lists.denx.de
> > https://lists.denx.de/listinfo/u-boot
> >
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot

Patch
diff mbox series

diff --git a/arch/arm/dts/armada-cp110-master.dtsi b/arch/arm/dts/armada-cp110-master.dtsi
index 551d00d774..6fb6166b79 100644
--- a/arch/arm/dts/armada-cp110-master.dtsi
+++ b/arch/arm/dts/armada-cp110-master.dtsi
@@ -96,6 +96,7 @@ 
 				#size-cells = <0>;
 				compatible = "marvell,orion-mdio";
 				reg = <0x12a200 0x10>;
+				device-name = "cpm";
 			};
 
 			cpm_syscon0: system-controller@440000 {
diff --git a/arch/arm/dts/armada-cp110-slave.dtsi b/arch/arm/dts/armada-cp110-slave.dtsi
index 2ea9004f1d..53c796dad6 100644
--- a/arch/arm/dts/armada-cp110-slave.dtsi
+++ b/arch/arm/dts/armada-cp110-slave.dtsi
@@ -96,6 +96,7 @@ 
 				#size-cells = <0>;
 				compatible = "marvell,orion-mdio";
 				reg = <0x12a200 0x10>;
+				device-name = "cps";
 			};
 
 			cps_syscon0: system-controller@440000 {