[1/1,SRU,D,OEM-OSP1-B] UBUNTU: SAUCE: i2c: designware: add G3 3590 into i2c quirk
diff mbox series

Message ID 20190717071324.2890-2-acelan.kao@canonical.com
State New
Headers show
Series
  • First click on Goodix touchpad doesn't be recognized while in runtime suspended
Related show

Commit Message

AceLan Kao July 17, 2019, 7:13 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1836836

Add one missing platform which uses Goodix touchpad IC into i2c designware
quirk to prevent touchpad from entering runtime suspend.

Signed-off-by: AceLan Kao <acelan.kao@canonical.com>
---
 drivers/i2c/busses/i2c-designware-master.c | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Stefan Bader July 19, 2019, 9:26 a.m. UTC | #1
On 17.07.19 09:13, AceLan Kao wrote:
> BugLink: https://bugs.launchpad.net/bugs/1836836
> 
> Add one missing platform which uses Goodix touchpad IC into i2c designware
> quirk to prevent touchpad from entering runtime suspend.
> 
> Signed-off-by: AceLan Kao <acelan.kao@canonical.com>
> ---
>  drivers/i2c/busses/i2c-designware-master.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/i2c/busses/i2c-designware-master.c b/drivers/i2c/busses/i2c-designware-master.c
> index d1063ef81ac6..53225b4263e8 100644
> --- a/drivers/i2c/busses/i2c-designware-master.c
> +++ b/drivers/i2c/busses/i2c-designware-master.c
> @@ -74,6 +74,13 @@ static const struct dmi_system_id i2c_dw_no_runtime_pm[] = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 7590"),

Wasn't there just recently another request which adds a Vostro 7591 here?
And again what about Unstable/Eoan?

-Stefan
>  		},
>  	},
> +	{
> +		.ident = "Dell G3 3590",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "G3 3590"),
> +		},
> +	},
>  	{ }
>  };
>  
>
AceLan Kao July 22, 2019, 1:56 a.m. UTC | #2
Hi Stefan,

Thanks for reminding the me Unstable/Eoan branches.
I found I've forgotten to submit other quirks to eoan, so I skipped
this one, too.
We're figuring out another solution for this issue, and it won't have
to add the platforms one by one,
after we verified the new fix on some platforms, we'll submit the fix
for all series.
Thanks.

Best regards,
AceLan Kao.

Stefan Bader <stefan.bader@canonical.com> 於 2019年7月19日 週五 下午5:26寫道:
>
> On 17.07.19 09:13, AceLan Kao wrote:
> > BugLink: https://bugs.launchpad.net/bugs/1836836
> >
> > Add one missing platform which uses Goodix touchpad IC into i2c designware
> > quirk to prevent touchpad from entering runtime suspend.
> >
> > Signed-off-by: AceLan Kao <acelan.kao@canonical.com>
> > ---
> >  drivers/i2c/busses/i2c-designware-master.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/i2c/busses/i2c-designware-master.c b/drivers/i2c/busses/i2c-designware-master.c
> > index d1063ef81ac6..53225b4263e8 100644
> > --- a/drivers/i2c/busses/i2c-designware-master.c
> > +++ b/drivers/i2c/busses/i2c-designware-master.c
> > @@ -74,6 +74,13 @@ static const struct dmi_system_id i2c_dw_no_runtime_pm[] = {
> >                       DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 7590"),
>
> Wasn't there just recently another request which adds a Vostro 7591 here?
> And again what about Unstable/Eoan?
>
> -Stefan
> >               },
> >       },
> > +     {
> > +             .ident = "Dell G3 3590",
> > +             .matches = {
> > +                     DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > +                     DMI_MATCH(DMI_PRODUCT_NAME, "G3 3590"),
> > +             },
> > +     },
> >       { }
> >  };
> >
> >
>
>
Stefan Bader July 22, 2019, 3:46 p.m. UTC | #3
On 22.07.19 03:56, AceLan Kao wrote:
> Hi Stefan,
> 
> Thanks for reminding the me Unstable/Eoan branches.
> I found I've forgotten to submit other quirks to eoan, so I skipped
> this one, too.
> We're figuring out another solution for this issue, and it won't have
> to add the platforms one by one,
> after we verified the new fix on some platforms, we'll submit the fix
> for all series.

In that case I would wait for that for the SRU into Disco.

-Stefan

> Thanks.
> 
> Best regards,
> AceLan Kao.
> 
> Stefan Bader <stefan.bader@canonical.com> 於 2019年7月19日 週五 下午5:26寫道:
>>
>> On 17.07.19 09:13, AceLan Kao wrote:
>>> BugLink: https://bugs.launchpad.net/bugs/1836836
>>>
>>> Add one missing platform which uses Goodix touchpad IC into i2c designware
>>> quirk to prevent touchpad from entering runtime suspend.
>>>
>>> Signed-off-by: AceLan Kao <acelan.kao@canonical.com>
>>> ---
>>>  drivers/i2c/busses/i2c-designware-master.c | 7 +++++++
>>>  1 file changed, 7 insertions(+)
>>>
>>> diff --git a/drivers/i2c/busses/i2c-designware-master.c b/drivers/i2c/busses/i2c-designware-master.c
>>> index d1063ef81ac6..53225b4263e8 100644
>>> --- a/drivers/i2c/busses/i2c-designware-master.c
>>> +++ b/drivers/i2c/busses/i2c-designware-master.c
>>> @@ -74,6 +74,13 @@ static const struct dmi_system_id i2c_dw_no_runtime_pm[] = {
>>>                       DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 7590"),
>>
>> Wasn't there just recently another request which adds a Vostro 7591 here?
>> And again what about Unstable/Eoan?
>>
>> -Stefan
>>>               },
>>>       },
>>> +     {
>>> +             .ident = "Dell G3 3590",
>>> +             .matches = {
>>> +                     DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
>>> +                     DMI_MATCH(DMI_PRODUCT_NAME, "G3 3590"),
>>> +             },
>>> +     },
>>>       { }
>>>  };
>>>
>>>
>>
>>

Patch
diff mbox series

diff --git a/drivers/i2c/busses/i2c-designware-master.c b/drivers/i2c/busses/i2c-designware-master.c
index d1063ef81ac6..53225b4263e8 100644
--- a/drivers/i2c/busses/i2c-designware-master.c
+++ b/drivers/i2c/busses/i2c-designware-master.c
@@ -74,6 +74,13 @@  static const struct dmi_system_id i2c_dw_no_runtime_pm[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 7590"),
 		},
 	},
+	{
+		.ident = "Dell G3 3590",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "G3 3590"),
+		},
+	},
 	{ }
 };