From patchwork Wed Jul 17 00:09:37 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alistair Francis X-Patchwork-Id: 1133015 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=sourceware.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=libc-alpha-return-103705-incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=wdc.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="jD9IwmVk"; dkim=pass (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.b="Gb+QJfRY"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45pHpJ1rJJz9sND for ; Wed, 17 Jul 2019 10:15:04 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; q=dns; s= default; b=lJU4wL7LpGhmtlZnAJ/D9gQpZBTxaYv8s46MbXCorLiIsG/FEnn9v 8s3EnriyzmJyLbTh7jWfOIL2AzyaDO4oq0N5ihqxi+4Jl4BJkDyox3vPW12fV4Si lWsAUdsEU0tzoq+c5KiJLhmHCP/Hb4hjNZ4/y9f/cPU8ZWvXdivndw= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; s=default; bh=sefyf0vQqt3APf9qt430G+j/xRw=; b=jD9IwmVkirxEKzyT9eqKrswj84RK FHxrYROZ8JWJdISuSWMQx8oVrKgU7c4LgKQjTnrTO8UadlrI9G5KaaUeysOB+98K IlwCgx+gWeNsRRHSYwm/8AjbsewqiRYgfARjeCf6qkSc6qA+0FXunojrqP2cNk4G Vnk/8u+LOZVokUQ= Received: (qmail 21709 invoked by alias); 17 Jul 2019 00:12:33 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 21567 invoked by uid 89); 17 Jul 2019 00:12:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_NUMSUBJECT, KAM_SHORT autolearn=ham version=3.3.1 spammy= X-HELO: esa2.hgst.iphmx.com DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1563322360; x=1594858360; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=znH1MVE3NS1jDE0/bXov7nnGvG9nbv4dlTGymXo6fuc=; b=Gb+QJfRY+tdO/MUqfqGxzGQGNWKYU3WNok3nMtf2Zd2ZphGlYTvHxnlT jtwkLBq3IdP0nEuphnKQvFPAzyTe8+/UPjMe9cVeiThQUQ4QGLCU8ahw3 j7eAlC4O/ogNAUnOU2YR0g5kvG9BdRVobxeEBfknqqGMJJL9+VkagV9Q9 cHA0lNBDaYvs+cA+GUaV6Yxtvelaj7+7Ga8x+UDNb32nySjbn/q8hasxG eeZeErVIwfj6zKKinPDjOz7G4naM4ThXcGPsKjmJAl4IoiBckts33yjva oOTOwF30EGXJ1oMBPRdQ/3dQozyUMIvxAstBs6mYf1IuHLyGag/cGTim/ A==; IronPort-SDR: WAZic+3jOIQVuVZDoeS1R4YVpbhts92AqUJEyse8bSdXott+EJwggqBCXwj5S3ErHXREeg98FB bkuUH/BTQ7n7hKVkT6aNoVEr9T0wvR7TjuXaKGgxLTEo/cuunpVwLQ80UR/DRk9wbbFxTCV/7a eVzOJliOr0GGdd76xx3+sA6pqRwtk2coZwbJqgekdyBTzo4aP58aUMJTIVf+H4/+zylbfuGJeW mANLDXM4KSZDL4BdoNEf1JYSlP/wKl6opojFuhpDGlfQRJHPR1J2lTGlyYokleaCiJwIuC4Jcm lNg= IronPort-SDR: 1pvjZPkvVqAS0rQApUHWjhI6+sFHvnSUEK/1OHm1zUt1MtlVpq0hXp5FCa4eXImo/T6cLz+tKm K3jxjSXJ7wJuaXH1u9zj3xTTlQKP07hseIKqDKcv9EiDjLkuBZCp9CxL4zTExRoZ1VaWTObxji YV0rdAGt1ZhS273w/lyYmiAmnSv14T2eHvkdpKhBviLFsJ80phWvUsd8jDKTVJwGSO0fCcgruz IjJP8wZIUDFodg0ytjordal23Q9hmqLel5ixCvOiRP2I6rIEqGhD3yaLMbaRsS5px53ESYI0Cl oLbHKCXy0bfxj7nyWOJHLQY9 IronPort-SDR: Q5xSgWdKpvCJZpH0taBPvWqoq/UhUX6x75F8qASNhGRt1FRS3iVtiWUz0Lrk0PLJwHDZ9PTrKD eptbeSrgLve1sIEWNMbHZTyqs2HuK18ijJCKxJkTA3gMf9pnOGUs8TASHpAnQ8I6Q4J+bpctl8 huy58EtT22q60wnyZj0RoPt6PW9szKwkggVsU7+ljdgt0RNoI9p0OLs52Hw8GEOtcEv2yLowde QYU3sSzOG38fZSS7VuPIc2I90jZ5nvi0Cn51PM3QY+/acECLIwMVwTyItY3waymdwRy5EgPXhA yU8= From: Alistair Francis To: libc-alpha@sourceware.org Cc: arnd@arndb.de, adhemerval.zanella@linaro.org, fweimer@redhat.com, palmer@sifive.com, macro@wdc.com, zongbox@gmail.com, alistair.francis@wdc.com, alistair23@gmail.com Subject: [RFC v3 21/23] RISC-V: Fix llrint and llround missing exceptions on RV32 Date: Tue, 16 Jul 2019 17:09:37 -0700 Message-Id: In-Reply-To: References: MIME-Version: 1.0 From: Zong Li Similar to the recent fix for MIPS, ARM and S/390, RV32 is missing correct exception on overflow from llrint and llround functions because cast from floating-point types to long long do not result in correct exceptions on overflow. 2018-11-29 Zong Li * sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h: New file. --- ChangeLog | 10 +++++ .../riscv/rv32/fix-fp-int-convert-overflow.h | 38 +++++++++++++++++++ 2 files changed, 48 insertions(+) create mode 100644 sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h diff --git a/ChangeLog b/ChangeLog index 131c1063fc..8b8b038b23 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1114,6 +1114,16 @@ * sysdeps/unix/sysv/linux/riscv/configure.ac: Likewise. * sysdeps/unix/sysv/linux/riscv/shlib-versions: Likewise. * sysdeps/riscv/preconfigure: Likewise. + * sysdeps/riscv/rv32/Implies-after: New file. + * sysdeps/riscv/rv32/rvd/Implies: Likewise. + * sysdeps/riscv/rv32/rvf/Implies: Likewise. + * sysdeps/unix/sysv/linux/riscv/rv32/Implies: Likewise. + * sysdeps/unix/sysv/linux/riscv/Makefile: Support rv32. + * sysdeps/unix/sysv/linux/riscv/configure: Likewise. + * sysdeps/unix/sysv/linux/riscv/configure.ac: Likewise. + * sysdeps/unix/sysv/linux/riscv/shlib-versions: Likewise. + * sysdeps/riscv/preconfigure: Likewise. + * sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h: New file. 2019-06-20 Dmitry V. Levin Florian Weimer diff --git a/sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h b/sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h new file mode 100644 index 0000000000..6b34a8415e --- /dev/null +++ b/sysdeps/riscv/rv32/fix-fp-int-convert-overflow.h @@ -0,0 +1,38 @@ +/* Fix for conversion of floating point to integer overflow. ARM version. + Copyright (C) 2015-2018 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#ifndef FIX_FP_INT_CONVERT_OVERFLOW_H +#define FIX_FP_INT_CONVERT_OVERFLOW_H 1 + +/* As of GCC 5, the generic libgcc2.c conversions from floating point + to long long may not raise the correct exceptions on overflow (and + may raise spurious "inexact" exceptions even in non-overflow cases, + see ). */ +#define FIX_FLT_LONG_CONVERT_OVERFLOW 0 +#define FIX_FLT_LLONG_CONVERT_OVERFLOW 1 + +#define FIX_DBL_LONG_CONVERT_OVERFLOW 0 +#define FIX_DBL_LLONG_CONVERT_OVERFLOW 1 + +#define FIX_LDBL_LONG_CONVERT_OVERFLOW 0 +#define FIX_LDBL_LLONG_CONVERT_OVERFLOW 0 + +#define FIX_FLT128_LONG_CONVERT_OVERFLOW 0 +#define FIX_FLT128_LLONG_CONVERT_OVERFLOW 0 + +#endif /* fix-fp-int-convert-overflow.h */