[U-Boot,1/1] travis-ci: qemu-system-riscv64: Parameter 'id' is missing
diff mbox series

Message ID 20190716233501.20016-1-xypron.glpk@gmx.de
State Accepted
Delegated to: Tom Rini
Headers show
Series
  • [U-Boot,1/1] travis-ci: qemu-system-riscv64: Parameter 'id' is missing
Related show

Commit Message

Heinrich Schuchardt July 16, 2019, 11:35 p.m. UTC
When testing qemu-riscv64_defconfig on Travis CI I got a QEMU erorr
"Parameter 'id' is missing".

A command launching qemu-riscv64_defconfig successfully on Debian is:

qemu-system-riscv64 \
-machine virt \
-kernel u-boot \
-m 1G -nographic -netdev user,id=net0,tftp=$tftpdir \
-device virtio-net-device,netdev=net0

Add the missing id.

Fixes: 990b317fdcc4 ("travis-ci: add qemu-riscv64")
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 bin/travis-ci/conf.qemu-riscv64_na | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.20.1

Comments

Bin Meng July 17, 2019, 2:29 a.m. UTC | #1
On Wed, Jul 17, 2019 at 7:36 AM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> When testing qemu-riscv64_defconfig on Travis CI I got a QEMU erorr
> "Parameter 'id' is missing".
>
> A command launching qemu-riscv64_defconfig successfully on Debian is:
>
> qemu-system-riscv64 \
> -machine virt \
> -kernel u-boot \
> -m 1G -nographic -netdev user,id=net0,tftp=$tftpdir \
> -device virtio-net-device,netdev=net0
>
> Add the missing id.
>
> Fixes: 990b317fdcc4 ("travis-ci: add qemu-riscv64")
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  bin/travis-ci/conf.qemu-riscv64_na | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Stephen Warren July 17, 2019, 4:02 p.m. UTC | #2
On 7/16/19 5:35 PM, Heinrich Schuchardt wrote:
> When testing qemu-riscv64_defconfig on Travis CI I got a QEMU erorr
> "Parameter 'id' is missing".
> 
> A command launching qemu-riscv64_defconfig successfully on Debian is:
> 
> qemu-system-riscv64 \
> -machine virt \
> -kernel u-boot \
> -m 1G -nographic -netdev user,id=net0,tftp=$tftpdir \
> -device virtio-net-device,netdev=net0
> 
> Add the missing id.

Thanks. I've applied this.
Heinrich Schuchardt July 17, 2019, 5:52 p.m. UTC | #3
On 7/17/19 6:02 PM, Stephen Warren wrote:
> On 7/16/19 5:35 PM, Heinrich Schuchardt wrote:
>> When testing qemu-riscv64_defconfig on Travis CI I got a QEMU erorr
>> "Parameter 'id' is missing".
>>
>> A command launching qemu-riscv64_defconfig successfully on Debian is:
>>
>> qemu-system-riscv64 \
>> -machine virt \
>> -kernel u-boot \
>> -m 1G -nographic -netdev user,id=net0,tftp=$tftpdir \
>> -device virtio-net-device,netdev=net0
>>
>> Add the missing id.
>
> Thanks. I've applied this.
>
Thanks

I was able to run a job successfully:
https://travis-ci.org/xypron2/u-boot/builds/560076658

So I will now proceed to update .travis.yml.

Best regards

Heinrich Schuchardt

Patch
diff mbox series

diff --git a/bin/travis-ci/conf.qemu-riscv64_na b/bin/travis-ci/conf.qemu-riscv64_na
index b375e2b..65b2096 100644
--- a/bin/travis-ci/conf.qemu-riscv64_na
+++ b/bin/travis-ci/conf.qemu-riscv64_na
@@ -5,7 +5,7 @@ 
 console_impl=qemu
 qemu_machine="virt"
 qemu_binary="qemu-system-riscv64"
-qemu_extra_args="-m 1G -nographic -netdev user,tftp=${UBOOT_TRAVIS_BUILD_DIR} -device virtio-net-device,netdev=user"
+qemu_extra_args="-m 1G -nographic -netdev user,id=net0,tftp=${UBOOT_TRAVIS_BUILD_DIR} -device virtio-net-device,netdev=net0"
 qemu_kernel_args="-kernel ${U_BOOT_BUILD_DIR}/u-boot"
 reset_impl=none
 flash_impl=none