| Message ID | 20190716211343.10792-1-pbonzini@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | kconfig: do not select VMMOUSE | expand |
Thanks Paolo On Tue, 2019-07-16 at 23:13 +0200, Paolo Bonzini wrote: > Just make it a default device, so that it is automatically removed if > VMPORT > is not included in the binary (as is the case with --with-default- > devices). > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > hw/i386/Kconfig | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig > index b9c96ac361..83a5d9c7c4 100644 > --- a/hw/i386/Kconfig > +++ b/hw/i386/Kconfig > @@ -59,7 +59,6 @@ config I440FX > select IDE_PIIX > select DIMM > select SMBIOS > - select VMMOUSE > select FW_CFG_DMA > > config ISAPC > @@ -85,7 +84,6 @@ config Q35 > select AHCI_ICH9 > select DIMM > select SMBIOS > - select VMMOUSE > select FW_CFG_DMA > > config VTD > @@ -99,4 +97,5 @@ config VMPORT > > config VMMOUSE > bool > + default y > depends on VMPORT Reviewed-by: Julio Montes <julio.montes@intel.com> Tested-by: Julio Montes <julio.montes@intel.com>
On 7/16/19 11:13 PM, Paolo Bonzini wrote: > Just make it a default device, so that it is automatically removed if VMPORT > is not included in the binary (as is the case with --with-default-devices). > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > hw/i386/Kconfig | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig > index b9c96ac361..83a5d9c7c4 100644 > --- a/hw/i386/Kconfig > +++ b/hw/i386/Kconfig > @@ -59,7 +59,6 @@ config I440FX > select IDE_PIIX > select DIMM > select SMBIOS > - select VMMOUSE > select FW_CFG_DMA > > config ISAPC > @@ -85,7 +84,6 @@ config Q35 > select AHCI_ICH9 > select DIMM > select SMBIOS > - select VMMOUSE > select FW_CFG_DMA > > config VTD > @@ -99,4 +97,5 @@ config VMPORT > > config VMMOUSE > bool > + default y > depends on VMPORT > Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig index b9c96ac361..83a5d9c7c4 100644 --- a/hw/i386/Kconfig +++ b/hw/i386/Kconfig @@ -59,7 +59,6 @@ config I440FX select IDE_PIIX select DIMM select SMBIOS - select VMMOUSE select FW_CFG_DMA config ISAPC @@ -85,7 +84,6 @@ config Q35 select AHCI_ICH9 select DIMM select SMBIOS - select VMMOUSE select FW_CFG_DMA config VTD @@ -99,4 +97,5 @@ config VMPORT config VMMOUSE bool + default y depends on VMPORT
Just make it a default device, so that it is automatically removed if VMPORT is not included in the binary (as is the case with --with-default-devices). Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- hw/i386/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)