[iproute2,net-next,v4,5/6] tc: etf: Add documentation for skip-skb-check.
diff mbox series

Message ID 1563306789-2908-5-git-send-email-vedang.patel@intel.com
State Changes Requested
Delegated to: David Ahern
Headers show
Series
  • [iproute2,net-next,v4,1/6] Update kernel headers
Related show

Commit Message

Patel, Vedang July 16, 2019, 7:53 p.m. UTC
Document the newly added option (skip-skb-check) on the etf man-page.

Signed-off-by: Vedang Patel <vedang.patel@intel.com>
---
 man/man8/tc-etf.8 | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

David Ahern July 18, 2019, 5:36 p.m. UTC | #1
On 7/16/19 1:53 PM, Vedang Patel wrote:
> Document the newly added option (skip-skb-check) on the etf man-page.
> 
> Signed-off-by: Vedang Patel <vedang.patel@intel.com>
> ---
>  man/man8/tc-etf.8 | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/man/man8/tc-etf.8 b/man/man8/tc-etf.8
> index 30a12de7d2c7..2e01a591dbaa 100644
> --- a/man/man8/tc-etf.8
> +++ b/man/man8/tc-etf.8
> @@ -106,6 +106,16 @@ referred to as "Launch Time" or "Time-Based Scheduling" by the
>  documentation of network interface controllers.
>  The default is for this option to be disabled.
>  
> +.TP
> +skip_skb_check

patch 1 adds skip_sock_check.

> +.br
> +.BR etf(8)
> +currently drops any packet which does not have a socket associated with it or
> +if the socket does not have SO_TXTIME socket option set. But, this will not
> +work if the launchtime is set by another entity inside the kernel (e.g. some
> +other Qdisc). Setting the skip_skb_check will skip checking for a socket
> +associated with the packet.
> +
>  .SH EXAMPLES
>  
>  ETF is used to enforce a Quality of Service. It controls when each
>
Patel, Vedang July 18, 2019, 7:46 p.m. UTC | #2
> On Jul 18, 2019, at 10:36 AM, David Ahern <dsahern@gmail.com> wrote:
> 
> On 7/16/19 1:53 PM, Vedang Patel wrote:
>> Document the newly added option (skip-skb-check) on the etf man-page.
>> 
>> Signed-off-by: Vedang Patel <vedang.patel@intel.com>
>> ---
>> man/man8/tc-etf.8 | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>> 
>> diff --git a/man/man8/tc-etf.8 b/man/man8/tc-etf.8
>> index 30a12de7d2c7..2e01a591dbaa 100644
>> --- a/man/man8/tc-etf.8
>> +++ b/man/man8/tc-etf.8
>> @@ -106,6 +106,16 @@ referred to as "Launch Time" or "Time-Based Scheduling" by the
>> documentation of network interface controllers.
>> The default is for this option to be disabled.
>> 
>> +.TP
>> +skip_skb_check
> 
> patch 1 adds skip_sock_check.
> 
Yes. I will fix this typo in the next version.

Thanks,
Vedang
>> +.br
>> +.BR etf(8)
>> +currently drops any packet which does not have a socket associated with it or
>> +if the socket does not have SO_TXTIME socket option set. But, this will not
>> +work if the launchtime is set by another entity inside the kernel (e.g. some
>> +other Qdisc). Setting the skip_skb_check will skip checking for a socket
>> +associated with the packet.
>> +
>> .SH EXAMPLES
>> 
>> ETF is used to enforce a Quality of Service. It controls when each

Patch
diff mbox series

diff --git a/man/man8/tc-etf.8 b/man/man8/tc-etf.8
index 30a12de7d2c7..2e01a591dbaa 100644
--- a/man/man8/tc-etf.8
+++ b/man/man8/tc-etf.8
@@ -106,6 +106,16 @@  referred to as "Launch Time" or "Time-Based Scheduling" by the
 documentation of network interface controllers.
 The default is for this option to be disabled.
 
+.TP
+skip_skb_check
+.br
+.BR etf(8)
+currently drops any packet which does not have a socket associated with it or
+if the socket does not have SO_TXTIME socket option set. But, this will not
+work if the launchtime is set by another entity inside the kernel (e.g. some
+other Qdisc). Setting the skip_skb_check will skip checking for a socket
+associated with the packet.
+
 .SH EXAMPLES
 
 ETF is used to enforce a Quality of Service. It controls when each