package/python-idna: select PYTHON3_UNICODEDATA
diff mbox series

Message ID 20190716175830.604552-1-alex_y_xu@yahoo.ca
State Changes Requested
Headers show
Series
  • package/python-idna: select PYTHON3_UNICODEDATA
Related show

Commit Message

Alex Xu (Hello71) July 16, 2019, 5:58 p.m. UTC
Signed-off-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca>
---
 package/python-idna/Config.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Petazzoni July 17, 2019, 6:43 a.m. UTC | #1
Hello Alex,

On Tue, 16 Jul 2019 13:58:30 -0400
"Alex Xu (Hello71)" <alex_y_xu@yahoo.ca> wrote:

> Signed-off-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca>

Thanks for your patch. However, the commit log is empty, and therefore
it doesn't carry any explanation as to why this change is necessary.
Could you give more details ?

> diff --git a/package/python-idna/Config.in b/package/python-idna/Config.in
> index 1fd56ceaf6..c247fa89d0 100644
> --- a/package/python-idna/Config.in
> +++ b/package/python-idna/Config.in
> @@ -1,5 +1,6 @@
>  config BR2_PACKAGE_PYTHON_IDNA
>  	bool "python-idna"
> +        select BR2_PACKAGE_PYTHON3_UNICODEDATA

Nit: there is an indentation problem, we indent those lines with a tab,
not with spaces.

Thanks!

Thomas

Patch
diff mbox series

diff --git a/package/python-idna/Config.in b/package/python-idna/Config.in
index 1fd56ceaf6..c247fa89d0 100644
--- a/package/python-idna/Config.in
+++ b/package/python-idna/Config.in
@@ -1,5 +1,6 @@ 
 config BR2_PACKAGE_PYTHON_IDNA
 	bool "python-idna"
+        select BR2_PACKAGE_PYTHON3_UNICODEDATA
 	help
 	  A library to support the Internationalised Domain Names in
 	  Applications (IDNA) protocol as specified in RFC 5891. This