[v2,2/2] Makefile: don't export GZIP environment variable
diff mbox series

Message ID 20190716174214.11914-2-itsatharva@gmail.com
State Accepted
Headers show
Series
  • [v2,1/2] fs/common.mk: do not store original names and timestamps when creating GZIP rootfs
Related show

Commit Message

Atharva Lele July 16, 2019, 5:42 p.m. UTC
We export GZIP = -n so that GZIP does not record original
name and timestamps. However..

GZIP environment variable is deprecated and soon will not be
supported in future GZIP versions. GZIP suggests the use of a
wrapper to pass options globally but it might be difficult to
implement in Buildroot. For now, we don't export the variable
and fix reproducibility issues per package as they show up in
Autobuilder.

Signed-off-by: Atharva Lele <itsatharva@gmail.com>
Acked-by: Yann E. MORIN <yann.morin.1998@free.fr>
---
Changes v1 -> v2:
  - Reversed order of patches
---
 Makefile | 1 -
 1 file changed, 1 deletion(-)

Comments

Peter Korsgaard Aug. 4, 2019, 8:12 p.m. UTC | #1
>>>>> "Atharva" == Atharva Lele <itsatharva@gmail.com> writes:

 > We export GZIP = -n so that GZIP does not record original
 > name and timestamps. However..

 > GZIP environment variable is deprecated and soon will not be
 > supported in future GZIP versions. GZIP suggests the use of a
 > wrapper to pass options globally but it might be difficult to
 > implement in Buildroot. For now, we don't export the variable
 > and fix reproducibility issues per package as they show up in
 > Autobuilder.

 > Signed-off-by: Atharva Lele <itsatharva@gmail.com>
 > Acked-by: Yann E. MORIN <yann.morin.1998@free.fr>
 > ---
 > Changes v1 -> v2:
 >   - Reversed order of patches

Committed to 2019.02.x and 2019.05.x, thanks.

Patch
diff mbox series

diff --git a/Makefile b/Makefile
index c98a0ed87e..9cce934990 100644
--- a/Makefile
+++ b/Makefile
@@ -248,7 +248,6 @@  ifeq ($(BR2_REPRODUCIBLE),y)
 export TZ = UTC
 export LANG = C
 export LC_ALL = C
-export GZIP = -n
 endif
 
 # To put more focus on warnings, be less verbose as default