Patchwork [net-next,3/3] ne2: silence static never defined warnings

login
register
mail settings
Submitter Ilpo Järvinen
Date Nov. 28, 2008, 5:53 p.m.
Message ID <1227894818582-git-send-email-ilpo.jarvinen@helsinki.fi>
Download mbox | patch
Permalink /patch/11323/
State Accepted
Delegated to: David Miller
Headers show

Comments

Ilpo Järvinen - Nov. 28, 2008, 5:53 p.m.
These warning originate from 50014f1 (ne2: convert to
net_device_ops) which did drop those functions.

drivers/net/ne2.c:140: warning: 'ne_open' declared 'static' but never defined
drivers/net/ne2.c:141: warning: 'ne_close' declared 'static' but never defined

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
---
 drivers/net/ne2.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
David Miller - Nov. 28, 2008, 11:55 p.m.
From: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Fri, 28 Nov 2008 19:53:38 +0200

> These warning originate from 50014f1 (ne2: convert to
> net_device_ops) which did drop those functions.
> 
> drivers/net/ne2.c:140: warning: 'ne_open' declared 'static' but never defined
> drivers/net/ne2.c:141: warning: 'ne_close' declared 'static' but never defined
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>

Also applied, thanks Ilpo.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/ne2.c b/drivers/net/ne2.c
index 8d61807..a53bb20 100644
--- a/drivers/net/ne2.c
+++ b/drivers/net/ne2.c
@@ -137,9 +137,6 @@  extern int netcard_probe(struct net_device *dev);
 
 static int ne2_probe1(struct net_device *dev, int slot);
 
-static int ne_open(struct net_device *dev);
-static int ne_close(struct net_device *dev);
-
 static void ne_reset_8390(struct net_device *dev);
 static void ne_get_8390_hdr(struct net_device *dev, struct e8390_pkt_hdr *hdr,
 		int ring_page);