From patchwork Sat Sep 3 08:33:19 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prasad Joshi X-Patchwork-Id: 113225 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id ECF5DB6F7F for ; Sat, 3 Sep 2011 18:33:29 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752730Ab1ICId2 (ORCPT ); Sat, 3 Sep 2011 04:33:28 -0400 Received: from mail-pz0-f66.google.com ([209.85.210.66]:49205 "EHLO mail-pz0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752350Ab1ICId1 (ORCPT ); Sat, 3 Sep 2011 04:33:27 -0400 Received: by pzk34 with SMTP id 34so2790493pzk.1 for ; Sat, 03 Sep 2011 01:33:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; bh=VAGLO601szol2OHtDITghfcwZqSyugxXyHv8Cm8xkdc=; b=sD0aFIdeDnsxaCwHSgur9Oy7KW6R1Sp5Gj12SLmghjbujPm/jfj3CBLKw2KXmvBhAS SK++PUNypF8CFR4u5HpcD2DLrnO2uhympzAL3aV9QIN74jI3DVFB99tv6ZzR7ya3XPK/ ID7OrwxM6n/lzVTaw5i+ohQdbYQDpjUxi5eAo= Received: by 10.68.17.9 with SMTP id k9mr3818844pbd.278.1315038807517; Sat, 03 Sep 2011 01:33:27 -0700 (PDT) Received: from prasad ([117.195.10.21]) by mx.google.com with ESMTPS id u10sm4452217pbr.12.2011.09.03.01.33.25 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 03 Sep 2011 01:33:27 -0700 (PDT) Received: by prasad (Postfix, from userid 1000) id 590C1A24F6; Sat, 3 Sep 2011 14:03:21 +0530 (IST) From: Prasad Joshi To: prasadjoshi.linux@gmail.com Cc: Chaitanya Kulkarni , xfs@oss.sgi.com, linux-ext4@vger.kernel.org Subject: [PATCH] xfstests: Assume yes when test device is not partitioned Date: Sat, 3 Sep 2011 14:03:19 +0530 Message-Id: <1315038799-2150-1-git-send-email-prasadjoshi.linux@gmail.com> X-Mailer: git-send-email 1.7.4.1 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org If an entire device used for file system creation, the mkfs.ext2/3/4 asks for confirmation before proceeding. Since the device is configured for testing it is safe to assume positive response during mkfs. The patch also replaces hard coded mkfs path with MKFS_PROG variable. Signed-off-by: Chaitanya Kulkarni Signed-off-by: Prasad Joshi Reviewed-by: Rich Johnston --- 032 | 4 ++-- 049 | 2 +- 073 | 2 +- common.rc | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/032 b/032 index 4261ca2..bf88492 100755 --- a/032 +++ b/032 @@ -45,7 +45,7 @@ _require_nobigloopfs _require_scratch echo "Silence is golden." -for fs in `echo /sbin/mkfs.* | sed -e 's/.sbin.mkfs.//g'` +for fs in `echo ${MKFS_PROG}.* | sed -e 's/.sbin.mkfs.//g'` do preop="" # for special input needs preargs="" # for any special pre-device options @@ -78,7 +78,7 @@ do if [ $? -eq 0 ] ; then # next, ensure we don't overwrite it echo "=== Attempting XFS overwrite of $fs..." >>$seq.full - /sbin/mkfs.xfs $SCRATCH_DEV >>$seq.full 2>&1 + ${MKFS_PROG}.xfs $SCRATCH_DEV >>$seq.full 2>&1 [ $? -eq 0 ] && echo "Failed - overwrote fs type ${fs}!" else diff --git a/049 b/049 index c6c4faa..8d4a22f 100755 --- a/049 +++ b/049 @@ -83,7 +83,7 @@ mount -t ext2 $SCRATCH_DEV $SCRATCH_MNT >> $seq.full 2>&1 \ || _fail "!!! failed to mount" _log "Create xfs fs in file on scratch" -/sbin/mkfs.xfs -f -dfile,name=$SCRATCH_MNT/test.xfs,size=40m \ +${MKFS_PROG}.xfs -f -dfile,name=$SCRATCH_MNT/test.xfs,size=40m \ >> $seq.full 2>&1 \ || _fail "!!! failed to mkfs xfs" diff --git a/073 b/073 index 18257d4..fc0951f 100755 --- a/073 +++ b/073 @@ -155,7 +155,7 @@ _verify_copy $imgs.image $SCRATCH_DEV $SCRATCH_MNT echo echo === copying scratch device to single target, large ro device -/sbin/mkfs.xfs -dfile,name=$imgs.source,size=100g | _filter_mkfs 2>/dev/null +${MKFS_PROG}.xfs -dfile,name=$imgs.source,size=100g | _filter_mkfs 2>/dev/null rmdir $imgs.source_dir 2>/dev/null mkdir $imgs.source_dir diff --git a/common.rc b/common.rc index 35f782b..a356c02 100644 --- a/common.rc +++ b/common.rc @@ -314,7 +314,7 @@ _scratch_mkfs() $MKFS_BTRFS_PROG $MKFS_OPTIONS $* $SCRATCH_DEV > /dev/null ;; *) - /sbin/mkfs -t $FSTYP -- $MKFS_OPTIONS $* $SCRATCH_DEV + yes | $MKFS_PROG -t $FSTYP -- $MKFS_OPTIONS $* $SCRATCH_DEV ;; esac } @@ -333,7 +333,7 @@ _scratch_mkfs_sized() _scratch_mkfs_xfs -d size=$fssize -b size=$blocksize ;; ext2|ext3|ext4|ext4dev) - /sbin/mkfs.$FSTYP $MKFS_OPTIONS -b $blocksize $SCRATCH_DEV $blocks + yes | ${MKFS_PROG}.$FSTYP $MKFS_OPTIONS -b $blocksize $SCRATCH_DEV $blocks ;; btrfs) $MKFS_BTRFS_PROG $MKFS_OPTIONS -b $fssize $SCRATCH_DEV