diff mbox series

[U-Boot,v3,03/18] ram: rk3399: Use rank mask in ca data training

Message ID 20190715182856.21688-4-jagan@amarulasolutions.com
State Accepted
Commit 708e9a79dc297aeb8a62dc6ba95b651b0493e1e1
Delegated to: Kever Yang
Headers show
Series ram: rk3399: Add rank detection | expand

Commit Message

Jagan Teki July 15, 2019, 6:28 p.m. UTC 
Add rank_mask based on the rank number, this would keep
the ca data training loop based on the desired rank mask
value instead of looping for all values.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
Signed-off-by: YouMin Chen <cym@rock-chips.com>
---
 drivers/ram/rockchip/sdram_rk3399.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

Comments

Kever Yang July 16, 2019, 7:38 a.m. UTC | #1 
On 2019/7/16 上午2:28, Jagan Teki wrote:
> Add rank_mask based on the rank number, this would keep
> the ca data training loop based on the desired rank mask
> value instead of looping for all values.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> Signed-off-by: YouMin Chen <cym@rock-chips.com>

Reviewed-by: Kever Yang <Kever.yang@rock-chips.com>

Thanks,
  - Kever
> ---
>   drivers/ram/rockchip/sdram_rk3399.c | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/ram/rockchip/sdram_rk3399.c b/drivers/ram/rockchip/sdram_rk3399.c
> index fe26144f27..b98df20fa5 100644
> --- a/drivers/ram/rockchip/sdram_rk3399.c
> +++ b/drivers/ram/rockchip/sdram_rk3399.c
> @@ -626,11 +626,17 @@ static int data_training_ca(const struct chan_info *chan, u32 channel,
>   	u32 i, tmp;
>   	u32 obs_0, obs_1, obs_2, obs_err = 0;
>   	u32 rank = params->ch[channel].cap_info.rank;
> +	u32 rank_mask;
>   
>   	/* clear interrupt,PI_175 PI_INT_ACK:WR:0:17 */
>   	writel(0x00003f7c, (&denali_pi[175]));
>   
> -	for (i = 0; i < rank; i++) {
> +	rank_mask = (rank == 1) ? 0x1 : 0x3;
> +
> +	for (i = 0; i < 4; i++) {
> +		if (!(rank_mask & (1 << i)))
> +			continue;
> +
>   		select_per_cs_training_index(chan, i);
>   
>   		/* PI_100 PI_CALVL_EN:RW:8:2 */
diff mbox series

Patch

diff --git a/drivers/ram/rockchip/sdram_rk3399.c b/drivers/ram/rockchip/sdram_rk3399.c
index fe26144f27..b98df20fa5 100644
--- a/drivers/ram/rockchip/sdram_rk3399.c
+++ b/drivers/ram/rockchip/sdram_rk3399.c
@@ -626,11 +626,17 @@  static int data_training_ca(const struct chan_info *chan, u32 channel,
 	u32 i, tmp;
 	u32 obs_0, obs_1, obs_2, obs_err = 0;
 	u32 rank = params->ch[channel].cap_info.rank;
+	u32 rank_mask;
 
 	/* clear interrupt,PI_175 PI_INT_ACK:WR:0:17 */
 	writel(0x00003f7c, (&denali_pi[175]));
 
-	for (i = 0; i < rank; i++) {
+	rank_mask = (rank == 1) ? 0x1 : 0x3;
+
+	for (i = 0; i < 4; i++) {
+		if (!(rank_mask & (1 << i)))
+			continue;
+
 		select_per_cs_training_index(chan, i);
 
 		/* PI_100 PI_CALVL_EN:RW:8:2 */