[3/3] s390x/cpumodel: change internal name of vxp to make description
diff mbox series

Message ID 20190715142304.215018-4-borntraeger@de.ibm.com
State New
Headers show
Series
  • s390x/cpumodel fixes for 4.1
Related show

Commit Message

Christian Borntraeger July 15, 2019, 2:23 p.m. UTC
The internal macro name VECTOR_BCD_ENH does not match the actual
description. Fix this.

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
 target/s390x/cpu_features_def.inc.h | 2 +-
 target/s390x/gen-features.c         | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

Comments

David Hildenbrand July 15, 2019, 2:37 p.m. UTC | #1
On 15.07.19 16:23, Christian Borntraeger wrote:
> The internal macro name VECTOR_BCD_ENH does not match the actual
> description. Fix this.
> 
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
>  target/s390x/cpu_features_def.inc.h | 2 +-
>  target/s390x/gen-features.c         | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/target/s390x/cpu_features_def.inc.h b/target/s390x/cpu_features_def.inc.h
> index 99f58a89318a..f7c52bc17c2e 100644
> --- a/target/s390x/cpu_features_def.inc.h
> +++ b/target/s390x/cpu_features_def.inc.h
> @@ -104,7 +104,7 @@ DEF_FEAT(CMM_NT, "cmmnt", STFL, 147, "CMM: ESSA-enhancement (no translate) facil
>  DEF_FEAT(VECTOR_ENH2, "vxeh2", STFL, 148, "Vector Enhancements facility 2")
>  DEF_FEAT(ESORT_BASE, "esort-base", STFL, 150, "Enhanced-sort facility (excluding subfunctions)")
>  DEF_FEAT(DEFLATE_BASE, "deflate-base", STFL, 151, "Deflate-conversion facility (excluding subfunctions)")
> -DEF_FEAT(VECTOR_BCD_ENH, "vxp", STFL, 152, "Vector-Packed-Decimal-Enhancement Facility")
> +DEF_FEAT(VECTOR_PACKED_DECIMAL_ENH, "vxp", STFL, 152, "Vector-Packed-Decimal-Enhancement Facility")
>  DEF_FEAT(MSA_EXT_9, "msa9-base", STFL, 155, "Message-security-assist-extension-9 facility (excluding subfunctions)")
>  DEF_FEAT(ETOKEN, "etoken", STFL, 156, "Etoken facility")
>  
> diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c
> index 6debfc1d217e..49a650ac52d0 100644
> --- a/target/s390x/gen-features.c
> +++ b/target/s390x/gen-features.c
> @@ -558,7 +558,7 @@ static uint16_t full_GEN15_GA1[] = {
>      S390_FEAT_VECTOR_ENH2,
>      S390_FEAT_GROUP_ENH_SORT,
>      S390_FEAT_GROUP_DEFLATE_CONVERSION,
> -    S390_FEAT_VECTOR_BCD_ENH,
> +    S390_FEAT_VECTOR_PACKED_DECIMAL_ENH,
>      S390_FEAT_GROUP_MSA_EXT_9,
>      S390_FEAT_GROUP_MSA_EXT_9_PCKMO,
>      S390_FEAT_ETOKEN,
> @@ -643,7 +643,7 @@ static uint16_t default_GEN14_GA1[] = {
>  static uint16_t default_GEN15_GA1[] = {
>      S390_FEAT_VECTOR_ENH2,
>      S390_FEAT_GROUP_DEFLATE_CONVERSION,
> -    S390_FEAT_VECTOR_BCD_ENH,
> +    S390_FEAT_VECTOR_PACKED_DECIMAL_ENH,
>      S390_FEAT_GROUP_MSA_EXT_9,
>      S390_FEAT_GROUP_MSA_EXT_9_PCKMO,
>      S390_FEAT_ETOKEN,
> 

Reviewed-by: David Hildenbrand <david@redhat.com>
Cornelia Huck July 15, 2019, 3:35 p.m. UTC | #2
On Mon, 15 Jul 2019 16:23:04 +0200
Christian Borntraeger <borntraeger@de.ibm.com> wrote:

> The internal macro name VECTOR_BCD_ENH does not match the actual
> description. Fix this.
> 
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
>  target/s390x/cpu_features_def.inc.h | 2 +-
>  target/s390x/gen-features.c         | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)

s/make/match/ in $SUBJECT?
Christian Borntraeger July 15, 2019, 3:51 p.m. UTC | #3
On 15.07.19 17:35, Cornelia Huck wrote:
> On Mon, 15 Jul 2019 16:23:04 +0200
> Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> 
>> The internal macro name VECTOR_BCD_ENH does not match the actual
>> description. Fix this.
>>
>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> ---
>>  target/s390x/cpu_features_def.inc.h | 2 +-
>>  target/s390x/gen-features.c         | 4 ++--
>>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> s/make/match/ in $SUBJECT?
> 
yep.
Thomas Huth July 16, 2019, 9:25 a.m. UTC | #4
On 15/07/2019 16.23, Christian Borntraeger wrote:
> The internal macro name VECTOR_BCD_ENH does not match the actual
> description. Fix this.
> 
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
>  target/s390x/cpu_features_def.inc.h | 2 +-
>  target/s390x/gen-features.c         | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/target/s390x/cpu_features_def.inc.h b/target/s390x/cpu_features_def.inc.h
> index 99f58a89318a..f7c52bc17c2e 100644
> --- a/target/s390x/cpu_features_def.inc.h
> +++ b/target/s390x/cpu_features_def.inc.h
> @@ -104,7 +104,7 @@ DEF_FEAT(CMM_NT, "cmmnt", STFL, 147, "CMM: ESSA-enhancement (no translate) facil
>  DEF_FEAT(VECTOR_ENH2, "vxeh2", STFL, 148, "Vector Enhancements facility 2")
>  DEF_FEAT(ESORT_BASE, "esort-base", STFL, 150, "Enhanced-sort facility (excluding subfunctions)")
>  DEF_FEAT(DEFLATE_BASE, "deflate-base", STFL, 151, "Deflate-conversion facility (excluding subfunctions)")
> -DEF_FEAT(VECTOR_BCD_ENH, "vxp", STFL, 152, "Vector-Packed-Decimal-Enhancement Facility")
> +DEF_FEAT(VECTOR_PACKED_DECIMAL_ENH, "vxp", STFL, 152, "Vector-Packed-Decimal-Enhancement Facility")

With "vxpdeh" instead of "vxp":

Reviewed-by: Thomas Huth <thuth@redhat.com>


>  DEF_FEAT(MSA_EXT_9, "msa9-base", STFL, 155, "Message-security-assist-extension-9 facility (excluding subfunctions)")
>  DEF_FEAT(ETOKEN, "etoken", STFL, 156, "Etoken facility")
>  
> diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c
> index 6debfc1d217e..49a650ac52d0 100644
> --- a/target/s390x/gen-features.c
> +++ b/target/s390x/gen-features.c
> @@ -558,7 +558,7 @@ static uint16_t full_GEN15_GA1[] = {
>      S390_FEAT_VECTOR_ENH2,
>      S390_FEAT_GROUP_ENH_SORT,
>      S390_FEAT_GROUP_DEFLATE_CONVERSION,
> -    S390_FEAT_VECTOR_BCD_ENH,
> +    S390_FEAT_VECTOR_PACKED_DECIMAL_ENH,
>      S390_FEAT_GROUP_MSA_EXT_9,
>      S390_FEAT_GROUP_MSA_EXT_9_PCKMO,
>      S390_FEAT_ETOKEN,
> @@ -643,7 +643,7 @@ static uint16_t default_GEN14_GA1[] = {
>  static uint16_t default_GEN15_GA1[] = {
>      S390_FEAT_VECTOR_ENH2,
>      S390_FEAT_GROUP_DEFLATE_CONVERSION,
> -    S390_FEAT_VECTOR_BCD_ENH,
> +    S390_FEAT_VECTOR_PACKED_DECIMAL_ENH,
>      S390_FEAT_GROUP_MSA_EXT_9,
>      S390_FEAT_GROUP_MSA_EXT_9_PCKMO,
>      S390_FEAT_ETOKEN,
>

Patch
diff mbox series

diff --git a/target/s390x/cpu_features_def.inc.h b/target/s390x/cpu_features_def.inc.h
index 99f58a89318a..f7c52bc17c2e 100644
--- a/target/s390x/cpu_features_def.inc.h
+++ b/target/s390x/cpu_features_def.inc.h
@@ -104,7 +104,7 @@  DEF_FEAT(CMM_NT, "cmmnt", STFL, 147, "CMM: ESSA-enhancement (no translate) facil
 DEF_FEAT(VECTOR_ENH2, "vxeh2", STFL, 148, "Vector Enhancements facility 2")
 DEF_FEAT(ESORT_BASE, "esort-base", STFL, 150, "Enhanced-sort facility (excluding subfunctions)")
 DEF_FEAT(DEFLATE_BASE, "deflate-base", STFL, 151, "Deflate-conversion facility (excluding subfunctions)")
-DEF_FEAT(VECTOR_BCD_ENH, "vxp", STFL, 152, "Vector-Packed-Decimal-Enhancement Facility")
+DEF_FEAT(VECTOR_PACKED_DECIMAL_ENH, "vxp", STFL, 152, "Vector-Packed-Decimal-Enhancement Facility")
 DEF_FEAT(MSA_EXT_9, "msa9-base", STFL, 155, "Message-security-assist-extension-9 facility (excluding subfunctions)")
 DEF_FEAT(ETOKEN, "etoken", STFL, 156, "Etoken facility")
 
diff --git a/target/s390x/gen-features.c b/target/s390x/gen-features.c
index 6debfc1d217e..49a650ac52d0 100644
--- a/target/s390x/gen-features.c
+++ b/target/s390x/gen-features.c
@@ -558,7 +558,7 @@  static uint16_t full_GEN15_GA1[] = {
     S390_FEAT_VECTOR_ENH2,
     S390_FEAT_GROUP_ENH_SORT,
     S390_FEAT_GROUP_DEFLATE_CONVERSION,
-    S390_FEAT_VECTOR_BCD_ENH,
+    S390_FEAT_VECTOR_PACKED_DECIMAL_ENH,
     S390_FEAT_GROUP_MSA_EXT_9,
     S390_FEAT_GROUP_MSA_EXT_9_PCKMO,
     S390_FEAT_ETOKEN,
@@ -643,7 +643,7 @@  static uint16_t default_GEN14_GA1[] = {
 static uint16_t default_GEN15_GA1[] = {
     S390_FEAT_VECTOR_ENH2,
     S390_FEAT_GROUP_DEFLATE_CONVERSION,
-    S390_FEAT_VECTOR_BCD_ENH,
+    S390_FEAT_VECTOR_PACKED_DECIMAL_ENH,
     S390_FEAT_GROUP_MSA_EXT_9,
     S390_FEAT_GROUP_MSA_EXT_9_PCKMO,
     S390_FEAT_ETOKEN,