diff mbox series

[U-Boot,v2,3/4] x86: acpi: Enable ACPI companion for Intel iDMA 32-bit

Message ID 20190714162359.56390-3-andriy.shevchenko@linux.intel.com
State Accepted
Commit e3be52ceac7fab098c47d1b7fd2f1456e8e43f7e
Delegated to: Bin Meng
Headers show
Series [U-Boot,v2,1/4] x86: acpi: Add CSRT description | expand

Commit Message

Andy Shevchenko July 14, 2019, 4:23 p.m. UTC
ACPI has a capability to specify DMA parameters for DMA channel consumers.
To enable this for Intel Edison, describe GP DMA device in ACPI table
in order to get an ACPI handle to it in OS.

This works in conjunction with CSRT, which must be in align with DSDT.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 .../asm/arch-tangier/acpi/southcluster.asl    | 22 +++++++++++++++++++
 1 file changed, 22 insertions(+)

Comments

Bin Meng July 18, 2019, 2:27 p.m. UTC | #1
On Mon, Jul 15, 2019 at 12:24 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> ACPI has a capability to specify DMA parameters for DMA channel consumers.
> To enable this for Intel Edison, describe GP DMA device in ACPI table
> in order to get an ACPI handle to it in OS.
>
> This works in conjunction with CSRT, which must be in align with DSDT.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  .../asm/arch-tangier/acpi/southcluster.asl    | 22 +++++++++++++++++++
>  1 file changed, 22 insertions(+)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Bin Meng July 19, 2019, 9:48 a.m. UTC | #2
On Thu, Jul 18, 2019 at 10:27 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> On Mon, Jul 15, 2019 at 12:24 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > ACPI has a capability to specify DMA parameters for DMA channel consumers.
> > To enable this for Intel Edison, describe GP DMA device in ACPI table
> > in order to get an ACPI handle to it in OS.
> >
> > This works in conjunction with CSRT, which must be in align with DSDT.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >  .../asm/arch-tangier/acpi/southcluster.asl    | 22 +++++++++++++++++++
> >  1 file changed, 22 insertions(+)
> >
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

applied to u-boot-x86, thanks!
diff mbox series

Patch

diff --git a/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl b/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl
index 241d4ac801..0ec195b51b 100644
--- a/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl
+++ b/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl
@@ -431,6 +431,28 @@  Device (PCI0)
             }
         }
     }
+
+    Device (GDMA)
+    {
+        Name (_ADR, 0x00150000)
+        Name (_HID, "808611A2")
+        Name (_UID, Zero)
+
+        Method (_STA, 0, NotSerialized)
+        {
+            Return (STA_VISIBLE)
+        }
+
+        Method (_CRS, 0, Serialized)
+        {
+            Name (RBUF, ResourceTemplate ()
+            {
+                    Memory32Fixed(ReadWrite, 0xFF192000, 0x00001000)
+                    Interrupt(ResourceConsumer, Level, ActiveHigh, Shared, ,, ) { 32 }
+            })
+            Return (RBUF)
+        }
+    }
 }
 
 Device (FLIS)