From patchwork Fri Jul 12 23:52:40 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saravana Kannan X-Patchwork-Id: 1131542 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="NuFa6cXO"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 45lqWV5YkQz9sNm for ; Sat, 13 Jul 2019 09:53:42 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727226AbfGLXxh (ORCPT ); Fri, 12 Jul 2019 19:53:37 -0400 Received: from mail-pl1-f202.google.com ([209.85.214.202]:41839 "EHLO mail-pl1-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728650AbfGLXxM (ORCPT ); Fri, 12 Jul 2019 19:53:12 -0400 Received: by mail-pl1-f202.google.com with SMTP id i3so6011452plb.8 for ; Fri, 12 Jul 2019 16:53:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=u0aCbzfqst+D0QpebqfgPDDHqeCzNETI6rpepbYOqAg=; b=NuFa6cXOZ03xsdBH/ZfK+iY9xs3bPy/PkCnlYauhFuo7hp8ItcNakBHm6+e4a6FW2/ Qy9eIPHN9QVYImgGz3vPgOgEL1Rh9APmS9LNzfVQyfr6nhAZXkcaPKv770hkuZ4I7FQo mPmItCpQQAy5CB2VrS/cMO2g4JsLM8S1emnd+9zU3+Xe0k044I2r6InPphZxx4momvaj 7uKzqvPnB8g0uXab+/biy4Ex+MSTlHVndbwTeKi+rsrxW1L6kkIj29IQXCIfhS160bMb o/0MTn6NSnijj7JgBcEIScY75jodS+cD0NP6BucvNliohtB+o9sS3ZOoYnFmDXIwDtgE sliw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=u0aCbzfqst+D0QpebqfgPDDHqeCzNETI6rpepbYOqAg=; b=grmDoGJFqIwSUFHI7t5iShVmuPMpTWOeop/OjGibQ2gvlA/bsidqraWcs4r0pZQiOS EZs8CfQmjYqAiT13ssgxPqEjSDIr/VgMt+FHXeI63umt/c98sHwoQvbBu5mrsRSdGMe+ 6EdhjZPyqoGV1O47+T+V/MREEz/lw/j6aphXCM5U7liahc3dxByMlcUO9POVoRhIpZCk UgDzumdUihz+AVz94RYXSGUdiU+RZbnxfDQOMMVIUKfhyKBhbP5XnpmVnkY1IMmeS7c5 4lT9pkZRa0qhYIbA4MINPfIdqbrEpUnfk1voCazzMfgr4B/55cJJWPDSTIibOxXdez6n 8ACA== X-Gm-Message-State: APjAAAXq2YxQYjBWRI3YuGfD81N3r7FxYV5w+CVL9HSdU/00jki87wE0 usljOBedNBC1Rgy5r77EvBadWBvT5ix4XH8= X-Google-Smtp-Source: APXvYqyWvabAfyxvg6UIJqiHNYu3Re+Ps/dXojaoKmsWOUDI0X+STCObr0nnDdxk3G7ga5ZyPciHY8ModRXmB94= X-Received: by 2002:a63:e90b:: with SMTP id i11mr14217259pgh.351.1562975591373; Fri, 12 Jul 2019 16:53:11 -0700 (PDT) Date: Fri, 12 Jul 2019 16:52:40 -0700 In-Reply-To: <20190712235245.202558-1-saravanak@google.com> Message-Id: <20190712235245.202558-8-saravanak@google.com> Mime-Version: 1.0 References: <20190712235245.202558-1-saravanak@google.com> X-Mailer: git-send-email 2.22.0.510.g264f2c817a-goog Subject: [PATCH v5 07/11] of/platform: Sanity check DT bindings before creating device links From: Saravana Kannan To: Rob Herring , Mark Rutland , Greg Kroah-Hartman , "Rafael J. Wysocki" , Frank Rowand Cc: Saravana Kannan , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, David Collins , kernel-team@android.com Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org If a common DT binding is pointing to a child DT node of a particular parent DT node, don't add device links for such DT references. This is because, by definition, a child node can't be a functional dependency for the parent node. Signed-off-by: Saravana Kannan --- drivers/of/platform.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/of/platform.c b/drivers/of/platform.c index dba962a0ee50..98414ba53b1f 100644 --- a/drivers/of/platform.c +++ b/drivers/of/platform.c @@ -512,6 +512,19 @@ int of_platform_default_populate(struct device_node *root, } EXPORT_SYMBOL_GPL(of_platform_default_populate); +bool of_link_is_valid(struct device_node *con, struct device_node *sup) +{ + of_node_get(sup); + while (sup) { + if (sup == con) { + of_node_put(sup); + return false; + } + sup = of_get_next_parent(sup); + } + return true; +} + static int of_link_binding(struct device *dev, const char *binding, const char *cell) { @@ -522,6 +535,10 @@ static int of_link_binding(struct device *dev, while (!of_parse_phandle_with_args(dev->of_node, binding, cell, i, &sup_args)) { + if (!of_link_is_valid(dev->of_node, sup_args.np)) { + of_node_put(sup_args.np); + continue; + } i++; sup_dev = of_find_device_by_node(sup_args.np); of_node_put(sup_args.np);