Patchwork [U-Boot,v3,7/8] km_arm: change CONFIG_SYS_TEXT_BASE to end of RAM

login
register
mail settings
Submitter Valentin Longchamp
Date Sept. 2, 2011, 2:59 p.m.
Message ID <1314975550-15766-8-git-send-email-valentin.longchamp@keymile.com>
Download mbox | patch
Permalink /patch/113148/
State Superseded
Headers show

Comments

Valentin Longchamp - Sept. 2, 2011, 2:59 p.m.
This allows to test a larger part of the RAM in the memory tests.

Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com>
Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
Cc: Prafulla Wadaskar <prafulla@marvell.com>
---
 include/configs/km/km_arm.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Heiko Schocher - Sept. 5, 2011, 6:35 a.m.
Hello Valentin,

Valentin Longchamp wrote:
> This allows to test a larger part of the RAM in the memory tests.
> 
> Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com>
> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
> Cc: Prafulla Wadaskar <prafulla@marvell.com>
> ---
>  include/configs/km/km_arm.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/configs/km/km_arm.h b/include/configs/km/km_arm.h
> index b1243ad..54c13ce 100644
> --- a/include/configs/km/km_arm.h
> +++ b/include/configs/km/km_arm.h
> @@ -54,7 +54,7 @@
>  
>  #include "asm/arch/config.h"
>  
> -#define CONFIG_SYS_TEXT_BASE	0x04000000	/* code address after reloc */
> +#define CONFIG_SYS_TEXT_BASE	0x07d00000	/* code address after reloc */

Hmm... are you really sure, this address is after relocation? I think
this comment is a hangover and should be deleted (or fixed to "code
address before relocation")

bye,
Heiko
Valentin Longchamp - Sept. 12, 2011, 12:21 p.m.
Hello Heiko,

On 09/05/2011 08:35 AM, Heiko Schocher wrote:
> Hello Valentin,
> 
> Valentin Longchamp wrote:
>> This allows to test a larger part of the RAM in the memory tests.
>>
>> Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com>
>> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
>> Cc: Prafulla Wadaskar <prafulla@marvell.com>
>> ---
>>  include/configs/km/km_arm.h |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/include/configs/km/km_arm.h b/include/configs/km/km_arm.h
>> index b1243ad..54c13ce 100644
>> --- a/include/configs/km/km_arm.h
>> +++ b/include/configs/km/km_arm.h
>> @@ -54,7 +54,7 @@
>>  
>>  #include "asm/arch/config.h"
>>  
>> -#define CONFIG_SYS_TEXT_BASE	0x04000000	/* code address after reloc */
>> +#define CONFIG_SYS_TEXT_BASE	0x07d00000	/* code address after reloc */
> 
> Hmm... are you really sure, this address is after relocation? I think
> this comment is a hangover and should be deleted (or fixed to "code
> address before relocation")

Yes, you are right, this is the code address before relocation. Will fix the
comment.

Patch

diff --git a/include/configs/km/km_arm.h b/include/configs/km/km_arm.h
index b1243ad..54c13ce 100644
--- a/include/configs/km/km_arm.h
+++ b/include/configs/km/km_arm.h
@@ -54,7 +54,7 @@ 
 
 #include "asm/arch/config.h"
 
-#define CONFIG_SYS_TEXT_BASE	0x04000000	/* code address after reloc */
+#define CONFIG_SYS_TEXT_BASE	0x07d00000	/* code address after reloc */
 #define CONFIG_SYS_MEMTEST_START 0x00400000	/* 4M */
 #define CONFIG_SYS_MEMTEST_END	0x007fffff	/*(_8M -1) */
 #define CONFIG_SYS_LOAD_ADDR	0x00800000	/* default load adr- 8M */