From patchwork Fri Jul 12 15:41:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Law X-Patchwork-Id: 1131442 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-505017-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="mKFjdkRy"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45lcbc5vWrz9s00 for ; Sat, 13 Jul 2019 01:41:32 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; q=dns; s=default; b=JIFgbaKziwmXNlaPG2RAxQQtGtrGreA2oMYeDaMdHBx1IaD2C7 ZSch86Rqjt4jUDSKKCiQ5hkGuPyBSJTZ6BuQ1IpI22svrrJ0yA52RzsSkIa/6UwB rJsAP/AcqOf2uqS8rypPzDKAVBCcqSAfUth4b0Bva3J+pi1Xm8Unhw2oM= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; s= default; bh=fU4v6kYuMAT/yJPjEbEPgpMUx5U=; b=mKFjdkRyKWndYdc4S2SH Z7cnh8RVN46y/K3he05TnnAj7NF/lkNHavVGVa5c1e0MOraCS1ZkZ3sLPuWt4nPP fvqhdJ8I3+V1/YN9KlMKLmlE0LUaPGxpBV/T7ky9RL1UCC3+Rro+oi+F7y4xYHQ0 uQWsbJ25b/Qc0R4GoQhPcO8= Received: (qmail 72207 invoked by alias); 12 Jul 2019 15:41:25 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 72199 invoked by uid 89); 12 Jul 2019 15:41:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=complaints, vast, correctness, hundred X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 12 Jul 2019 15:41:23 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 81D8E3092652 for ; Fri, 12 Jul 2019 15:41:22 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-12.rdu2.redhat.com [10.10.112.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id EA1C8600CD for ; Fri, 12 Jul 2019 15:41:21 +0000 (UTC) To: gcc-patches From: Jeff Law Subject: [committed] Fix thousands of testsuite failures for the c6x Openpgp: preference=signencrypt Message-ID: <26c15b83-5f3c-224c-edbe-67d9f4735308@redhat.com> Date: Fri, 12 Jul 2019 09:41:20 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 X-IsSubscribed: yes My tester reports ~22000 unexpected failures for the c6x port. The vast majority are due to a linker warning when the type of the .far section changes. It turns out we can emit two declarations for the .far section. One with @nobits, the other without. And since the .far section is a bss section the linker complains. Those complaints are picked up by dejagnu and thus every test that links fails. This patch clears the SECTION_NOTYPE flag for the .far section in the path that declares the .far section without the @nobits tag. The net result is we go from ~22000 failures to just several hundred (note I'm using a dummy simulator that always signals success -- so it's not testing code correctness, just that we can compile/link). Committed to the trunk. Jeff commit 713c53b30d7b74df412c89a11f4714e0ca08ee22 Author: Jeff Law Date: Fri Jul 12 09:40:16 2019 -0600 * config/c6x/c6x.c (c6x_section_type): Clear SECTION_NOTYPE for the ".far" section. diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 84fee9e0dd9..4f32256c8d8 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2019-07-12 Jeff Law + + * config/c6x/c6x.c (c6x_section_type): Clear SECTION_NOTYPE + for the ".far" section. + 2019-07-12 Richard Biener PR tree-optimization/91145 diff --git a/gcc/config/c6x/c6x.c b/gcc/config/c6x/c6x.c index 93841e4abef..f6c9bbfc674 100644 --- a/gcc/config/c6x/c6x.c +++ b/gcc/config/c6x/c6x.c @@ -1083,6 +1083,14 @@ c6x_section_type_flags (tree decl, const char *name, int reloc) flags |= default_section_type_flags (decl, name, reloc); + /* The ".far" section will be declared with @nobits elsewhere. + But when declared via this path it will not have the @nobits + flag because of SECTION_NOTYPE. This causes linker warnings + due to the mismatched attribute. Clearing SECTION_NOTYPE + for the ".far" section is sufficient to fix this problem. */ + if (strcmp (name, ".far") == 0) + flags &= ~SECTION_NOTYPE; + return flags; }