From patchwork Fri Sep 2 14:02:18 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 113143 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 76B32B6F83 for ; Sat, 3 Sep 2011 00:02:06 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 7FE9A281CC; Fri, 2 Sep 2011 16:02:04 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7sJHnDZ0h9aY; Fri, 2 Sep 2011 16:02:04 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 70DA2281C1; Fri, 2 Sep 2011 16:02:02 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 49824281C4 for ; Fri, 2 Sep 2011 16:02:00 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Rxxcl54udqjf for ; Fri, 2 Sep 2011 16:01:59 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from DB3EHSOBE002.bigfish.com (db3ehsobe002.messaging.microsoft.com [213.199.154.140]) by theia.denx.de (Postfix) with ESMTPS id 364A1281BF for ; Fri, 2 Sep 2011 16:01:57 +0200 (CEST) Received: from mail81-db3-R.bigfish.com (10.3.81.252) by DB3EHSOBE002.bigfish.com (10.3.84.22) with Microsoft SMTP Server id 14.1.225.22; Fri, 2 Sep 2011 14:01:56 +0000 Received: from mail81-db3 (localhost.localdomain [127.0.0.1]) by mail81-db3-R.bigfish.com (Postfix) with ESMTP id E02183202EF; Fri, 2 Sep 2011 14:01:56 +0000 (UTC) X-SpamScore: 0 X-BigFish: VS0(zzzz1202hzz8275bhz2dh2a8h668h839h61h) X-Spam-TCS-SCL: 0:0 X-Forefront-Antispam-Report: CIP:70.37.183.190; KIP:(null); UIP:(null); IPVD:NLI; H:mail.freescale.net; RD:none; EFVD:NLI Received: from mail81-db3 (localhost.localdomain [127.0.0.1]) by mail81-db3 (MessageSwitch) id 1314972116741162_3810; Fri, 2 Sep 2011 14:01:56 +0000 (UTC) Received: from DB3EHSMHS012.bigfish.com (unknown [10.3.81.247]) by mail81-db3.bigfish.com (Postfix) with ESMTP id A579222004D; Fri, 2 Sep 2011 14:01:56 +0000 (UTC) Received: from mail.freescale.net (70.37.183.190) by DB3EHSMHS012.bigfish.com (10.3.87.112) with Microsoft SMTP Server (TLS) id 14.1.225.22; Fri, 2 Sep 2011 14:01:52 +0000 Received: from az33smr01.freescale.net (10.64.34.199) by 039-SN1MMR1-003.039d.mgd.msft.net (10.84.1.16) with Microsoft SMTP Server id 14.1.323.2; Fri, 2 Sep 2011 09:01:50 -0500 Received: from fabio-Latitude-E6410.am.freescale.net ([10.29.240.191]) by az33smr01.freescale.net (8.13.1/8.13.0) with ESMTP id p82E1mY2000772; Fri, 2 Sep 2011 09:01:48 -0500 (CDT) From: Fabio Estevam To: Date: Fri, 2 Sep 2011 11:02:18 -0300 Message-ID: <1314972139-20068-1-git-send-email-fabio.estevam@freescale.com> X-Mailer: git-send-email 1.7.1 MIME-Version: 1.0 X-OriginatorOrg: freescale.com Cc: Fabio Estevam Subject: [U-Boot] [PATCH v3 1/2] MX25: tx25: Avoid the usage of extern in C file X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.9 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de Avoid the usage of extern in C file as pointed out by checkpatch. Signed-off-by: Fabio Estevam --- Changes since v2: - Place the extern in the MX25 imx-regs.h instead of inside the MX27 imx-regs.h Changes since v1: - No changes arch/arm/include/asm/arch-mx25/imx-regs.h | 1 + board/karo/tx25/tx25.c | 1 - 2 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/include/asm/arch-mx25/imx-regs.h b/arch/arm/include/asm/arch-mx25/imx-regs.h index 9e30f7c..7e34050 100644 --- a/arch/arm/include/asm/arch-mx25/imx-regs.h +++ b/arch/arm/include/asm/arch-mx25/imx-regs.h @@ -37,6 +37,7 @@ #ifdef CONFIG_FEC_MXC extern void mx25_fec_init_pins(void); extern void imx_get_mac_from_fuse(unsigned char *mac); +extern void mx25_uart1_init_pins(void); #endif /* Clock Control Module (CCM) registers */ diff --git a/board/karo/tx25/tx25.c b/board/karo/tx25/tx25.c index 25b99e8..2787715 100644 --- a/board/karo/tx25/tx25.c +++ b/board/karo/tx25/tx25.c @@ -141,7 +141,6 @@ void tx25_fec_init(void) int board_init() { #ifdef CONFIG_MXC_UART - extern void mx25_uart1_init_pins(void); mx25_uart1_init_pins(); #endif