| Message ID | 20190712134307.31112-1-sw@weilnetz.de |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] Remove old global variables max_cpus and smp_cpus | expand |
Le 12/07/2019 à 15:43, Stefan Weil a écrit : > Signed-off-by: Stefan Weil <sw@weilnetz.de> > --- > v2: Remove also max_cpus (merci à Laurent Vivier <laurent@vivier.eu>) > > include/sysemu/sysemu.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h > index 984c439ac9..e70edf7c1c 100644 > --- a/include/sysemu/sysemu.h > +++ b/include/sysemu/sysemu.h > @@ -103,8 +103,6 @@ extern const char *keyboard_layout; > extern int win2k_install_hack; > extern int alt_grab; > extern int ctrl_grab; > -extern int smp_cpus; > -extern unsigned int max_cpus; > extern int cursor_hide; > extern int graphic_rotate; > extern int no_quit; > Reviewed-by: Laurent Vivier <laurent@vivier.eu>
On Fri, 12 Jul 2019 at 14:43, Stefan Weil <sw@weilnetz.de> wrote: > > Signed-off-by: Stefan Weil <sw@weilnetz.de> > --- > v2: Remove also max_cpus (merci à Laurent Vivier <laurent@vivier.eu>) > > include/sysemu/sysemu.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h > index 984c439ac9..e70edf7c1c 100644 > --- a/include/sysemu/sysemu.h > +++ b/include/sysemu/sysemu.h > @@ -103,8 +103,6 @@ extern const char *keyboard_layout; > extern int win2k_install_hack; > extern int alt_grab; > extern int ctrl_grab; > -extern int smp_cpus; > -extern unsigned int max_cpus; > extern int cursor_hide; > extern int graphic_rotate; > extern int no_quit; Hi -- this looks like an inadvertent duplicate of Alex's patch from yesterday: https://patchew.org/QEMU/20190711130546.18578-1-alex.bennee@linaro.org/ thanks -- PMM
On Fri, Jul 12, 2019 at 03:43:07PM +0200, Stefan Weil wrote: > Signed-off-by: Stefan Weil <sw@weilnetz.de> > --- > v2: Remove also max_cpus (merci à Laurent Vivier <laurent@vivier.eu>) > > include/sysemu/sysemu.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h > index 984c439ac9..e70edf7c1c 100644 > --- a/include/sysemu/sysemu.h > +++ b/include/sysemu/sysemu.h > @@ -103,8 +103,6 @@ extern const char *keyboard_layout; > extern int win2k_install_hack; > extern int alt_grab; > extern int ctrl_grab; > -extern int smp_cpus; > -extern unsigned int max_cpus; > extern int cursor_hide; > extern int graphic_rotate; > extern int no_quit; > -- > 2.20.1 > Queued for 4.2, thanks!
Le 23/07/2019 à 15:53, Eduardo Habkost a écrit : > On Fri, Jul 12, 2019 at 03:43:07PM +0200, Stefan Weil wrote: >> Signed-off-by: Stefan Weil <sw@weilnetz.de> >> --- >> v2: Remove also max_cpus (merci à Laurent Vivier <laurent@vivier.eu>) >> >> include/sysemu/sysemu.h | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h >> index 984c439ac9..e70edf7c1c 100644 >> --- a/include/sysemu/sysemu.h >> +++ b/include/sysemu/sysemu.h >> @@ -103,8 +103,6 @@ extern const char *keyboard_layout; >> extern int win2k_install_hack; >> extern int alt_grab; >> extern int ctrl_grab; >> -extern int smp_cpus; >> -extern unsigned int max_cpus; >> extern int cursor_hide; >> extern int graphic_rotate; >> extern int no_quit; >> -- >> 2.20.1 >> > > Queued for 4.2, thanks! > Hi did you the mail from Peter? "this looks like an inadvertent duplicate of Alex's patch from yesterday: https://patchew.org/QEMU/20190711130546.18578-1-alex.bennee@linaro.org/" Thanks, Laurent
On Tue, Jul 23, 2019 at 03:54:56PM +0200, Laurent Vivier wrote: > Le 23/07/2019 à 15:53, Eduardo Habkost a écrit : > > On Fri, Jul 12, 2019 at 03:43:07PM +0200, Stefan Weil wrote: > >> Signed-off-by: Stefan Weil <sw@weilnetz.de> > >> --- > >> v2: Remove also max_cpus (merci à Laurent Vivier <laurent@vivier.eu>) > >> > >> include/sysemu/sysemu.h | 2 -- > >> 1 file changed, 2 deletions(-) > >> > >> diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h > >> index 984c439ac9..e70edf7c1c 100644 > >> --- a/include/sysemu/sysemu.h > >> +++ b/include/sysemu/sysemu.h > >> @@ -103,8 +103,6 @@ extern const char *keyboard_layout; > >> extern int win2k_install_hack; > >> extern int alt_grab; > >> extern int ctrl_grab; > >> -extern int smp_cpus; > >> -extern unsigned int max_cpus; > >> extern int cursor_hide; > >> extern int graphic_rotate; > >> extern int no_quit; > >> -- > >> 2.20.1 > >> > > > > Queued for 4.2, thanks! > > > > Hi did you the mail from Peter? > > "this looks like an inadvertent duplicate of Alex's > patch from yesterday: > > https://patchew.org/QEMU/20190711130546.18578-1-alex.bennee@linaro.org/" I did, but I hadn't realized the other patch was older. I will replace it.
diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h index 984c439ac9..e70edf7c1c 100644 --- a/include/sysemu/sysemu.h +++ b/include/sysemu/sysemu.h @@ -103,8 +103,6 @@ extern const char *keyboard_layout; extern int win2k_install_hack; extern int alt_grab; extern int ctrl_grab; -extern int smp_cpus; -extern unsigned int max_cpus; extern int cursor_hide; extern int graphic_rotate; extern int no_quit;
Signed-off-by: Stefan Weil <sw@weilnetz.de> --- v2: Remove also max_cpus (merci à Laurent Vivier <laurent@vivier.eu>) include/sysemu/sysemu.h | 2 -- 1 file changed, 2 deletions(-)