[-next] pinctrl: aspeed: Make aspeed_pinmux_ips static
diff mbox series

Message ID 20190711142457.37028-1-yuehaibing@huawei.com
State New
Headers show
Series
  • [-next] pinctrl: aspeed: Make aspeed_pinmux_ips static
Related show

Commit Message

YueHaibing July 11, 2019, 2:24 p.m. UTC
Fix sparse warning:

drivers/pinctrl/aspeed/pinmux-aspeed.c:8:12: warning:
 symbol 'aspeed_pinmux_ips' was not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/pinctrl/aspeed/pinmux-aspeed.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andrew Jeffery July 12, 2019, 12:56 a.m. UTC | #1
On Thu, 11 Jul 2019, at 23:55, YueHaibing wrote:
> Fix sparse warning:
> 
> drivers/pinctrl/aspeed/pinmux-aspeed.c:8:12: warning:
>  symbol 'aspeed_pinmux_ips' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Reviewed-by: Andrew Jeffery <andrew@aj.id.au>

> ---
>  drivers/pinctrl/aspeed/pinmux-aspeed.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/aspeed/pinmux-aspeed.c 
> b/drivers/pinctrl/aspeed/pinmux-aspeed.c
> index 5b0fe17..839c01b 100644
> --- a/drivers/pinctrl/aspeed/pinmux-aspeed.c
> +++ b/drivers/pinctrl/aspeed/pinmux-aspeed.c
> @@ -5,7 +5,7 @@
>  
>  #include "pinmux-aspeed.h"
>  
> -const char *const aspeed_pinmux_ips[] = {
> +static const char *const aspeed_pinmux_ips[] = {
>  	[ASPEED_IP_SCU] = "SCU",
>  	[ASPEED_IP_GFX] = "GFX",
>  	[ASPEED_IP_LPC] = "LPC",
> -- 
> 2.7.4
> 
> 
>
Linus Walleij July 29, 2019, 9:36 p.m. UTC | #2
On Thu, Jul 11, 2019 at 4:25 PM YueHaibing <yuehaibing@huawei.com> wrote:

> Fix sparse warning:
>
> drivers/pinctrl/aspeed/pinmux-aspeed.c:8:12: warning:
>  symbol 'aspeed_pinmux_ips' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Patch applied with Andrew's ACK.

Yours,
Linus Walleij

Patch
diff mbox series

diff --git a/drivers/pinctrl/aspeed/pinmux-aspeed.c b/drivers/pinctrl/aspeed/pinmux-aspeed.c
index 5b0fe17..839c01b 100644
--- a/drivers/pinctrl/aspeed/pinmux-aspeed.c
+++ b/drivers/pinctrl/aspeed/pinmux-aspeed.c
@@ -5,7 +5,7 @@ 
 
 #include "pinmux-aspeed.h"
 
-const char *const aspeed_pinmux_ips[] = {
+static const char *const aspeed_pinmux_ips[] = {
 	[ASPEED_IP_SCU] = "SCU",
 	[ASPEED_IP_GFX] = "GFX",
 	[ASPEED_IP_LPC] = "LPC",