[1/1,SRU,D,OEM-OSP1-B] UBUNTU: SAUCE: i2c: designware: add Inpiron 7591 into i2c quirk
diff mbox series

Message ID 20190711085839.5473-2-acelan.kao@canonical.com
State New
Headers show
Series
  • [1/1,SRU,D,OEM-OSP1-B] UBUNTU: SAUCE: i2c: designware: add Inpiron 7591 into i2c quirk
Related show

Commit Message

AceLan Kao July 11, 2019, 8:58 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1836020

Add one missing platform which uses Goodix touchpad IC into i2c designware
quirk to prevent touchpad from entering runtime suspend.

Signed-off-by: AceLan Kao <acelan.kao@canonical.com>
---
 drivers/i2c/busses/i2c-designware-master.c | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Stefan Bader July 19, 2019, 8:59 a.m. UTC | #1
On 11.07.19 10:58, AceLan Kao wrote:
> BugLink: https://bugs.launchpad.net/bugs/1836020
> 
> Add one missing platform which uses Goodix touchpad IC into i2c designware
> quirk to prevent touchpad from entering runtime suspend.
> 
> Signed-off-by: AceLan Kao <acelan.kao@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
> ---

The way this is submitted is confusing and somewhat prone to errors. The patch
depends on the other addition to the quirks for the 7590 but as it is submitted
independently it could get picked up before the other one. I only looked closer
because the status of the bug report already is fix-committed which sounded wrong.

In this case I think it would be better to submit a follow-up v2 which carries
both patches and self-NACK the initial one. Or, if the first patch already is
applied, then follow-up with the additional patch on the initial thread.

-Stefan

>  drivers/i2c/busses/i2c-designware-master.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/i2c/busses/i2c-designware-master.c b/drivers/i2c/busses/i2c-designware-master.c
> index 00a906ec43be..d1063ef81ac6 100644
> --- a/drivers/i2c/busses/i2c-designware-master.c
> +++ b/drivers/i2c/busses/i2c-designware-master.c
> @@ -46,6 +46,13 @@ static const struct dmi_system_id i2c_dw_no_runtime_pm[] = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 7590"),
>  		},
>  	},
> +	{
> +		.ident = "Dell Inspiron 7591",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 7591"),
> +		},
> +	},
>  	{
>  		.ident = "Dell Vostro 5390",
>  		.matches = {
>
Stefan Bader July 22, 2019, 3:45 p.m. UTC | #2
On 11.07.19 10:58, AceLan Kao wrote:
> BugLink: https://bugs.launchpad.net/bugs/1836020
> 
> Add one missing platform which uses Goodix touchpad IC into i2c designware
> quirk to prevent touchpad from entering runtime suspend.
> 
> Signed-off-by: AceLan Kao <acelan.kao@canonical.com>
> ---

Though we have applied the Inspiron 7590 part already, there was another
follow-up patch where it was said that the approach will be re-worked. So I
would rather wait for that for SRU into Disco.

-Stefan

>  drivers/i2c/busses/i2c-designware-master.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/i2c/busses/i2c-designware-master.c b/drivers/i2c/busses/i2c-designware-master.c
> index 00a906ec43be..d1063ef81ac6 100644
> --- a/drivers/i2c/busses/i2c-designware-master.c
> +++ b/drivers/i2c/busses/i2c-designware-master.c
> @@ -46,6 +46,13 @@ static const struct dmi_system_id i2c_dw_no_runtime_pm[] = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 7590"),
>  		},
>  	},
> +	{
> +		.ident = "Dell Inspiron 7591",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 7591"),
> +		},
> +	},
>  	{
>  		.ident = "Dell Vostro 5390",
>  		.matches = {
>

Patch
diff mbox series

diff --git a/drivers/i2c/busses/i2c-designware-master.c b/drivers/i2c/busses/i2c-designware-master.c
index 00a906ec43be..d1063ef81ac6 100644
--- a/drivers/i2c/busses/i2c-designware-master.c
+++ b/drivers/i2c/busses/i2c-designware-master.c
@@ -46,6 +46,13 @@  static const struct dmi_system_id i2c_dw_no_runtime_pm[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 7590"),
 		},
 	},
+	{
+		.ident = "Dell Inspiron 7591",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 7591"),
+		},
+	},
 	{
 		.ident = "Dell Vostro 5390",
 		.matches = {