migration/postcopy: PostcopyState is already set in loadvm_postcopy_handle_advise()
diff mbox series

Message ID 20190711080816.6405-1-richardw.yang@linux.intel.com
State New
Headers show
Series
  • migration/postcopy: PostcopyState is already set in loadvm_postcopy_handle_advise()
Related show

Commit Message

Wei Yang July 11, 2019, 8:08 a.m. UTC
PostcopyState is already set to ADVISE at the beginning of
loadvm_postcopy_handle_advise().

Remove the redundant set.

Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
---
 migration/savevm.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Wei Yang Aug. 5, 2019, 2:03 a.m. UTC | #1
On Thu, Jul 11, 2019 at 04:08:16PM +0800, Wei Yang wrote:
>PostcopyState is already set to ADVISE at the beginning of
>loadvm_postcopy_handle_advise().
>
>Remove the redundant set.

Ping~

>
>Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>---
> migration/savevm.c | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/migration/savevm.c b/migration/savevm.c
>index 8a2ada529e..2350e219fc 100644
>--- a/migration/savevm.c
>+++ b/migration/savevm.c
>@@ -1648,8 +1648,6 @@ static int loadvm_postcopy_handle_advise(MigrationIncomingState *mis,
>         return -1;
>     }
> 
>-    postcopy_state_set(POSTCOPY_INCOMING_ADVISE);
>-
>     return 0;
> }
> 
>-- 
>2.17.1
Dr. David Alan Gilbert Aug. 5, 2019, 9:34 a.m. UTC | #2
* Wei Yang (richardw.yang@linux.intel.com) wrote:
> PostcopyState is already set to ADVISE at the beginning of
> loadvm_postcopy_handle_advise().
> 
> Remove the redundant set.
> 
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

> ---
>  migration/savevm.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/migration/savevm.c b/migration/savevm.c
> index 8a2ada529e..2350e219fc 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -1648,8 +1648,6 @@ static int loadvm_postcopy_handle_advise(MigrationIncomingState *mis,
>          return -1;
>      }
>  
> -    postcopy_state_set(POSTCOPY_INCOMING_ADVISE);
> -
>      return 0;
>  }
>  
> -- 
> 2.17.1
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
Dr. David Alan Gilbert Aug. 7, 2019, 5:34 p.m. UTC | #3
* Wei Yang (richardw.yang@linux.intel.com) wrote:
> PostcopyState is already set to ADVISE at the beginning of
> loadvm_postcopy_handle_advise().
> 
> Remove the redundant set.
> 
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>

Queued

> ---
>  migration/savevm.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/migration/savevm.c b/migration/savevm.c
> index 8a2ada529e..2350e219fc 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -1648,8 +1648,6 @@ static int loadvm_postcopy_handle_advise(MigrationIncomingState *mis,
>          return -1;
>      }
>  
> -    postcopy_state_set(POSTCOPY_INCOMING_ADVISE);
> -
>      return 0;
>  }
>  
> -- 
> 2.17.1
> 
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

Patch
diff mbox series

diff --git a/migration/savevm.c b/migration/savevm.c
index 8a2ada529e..2350e219fc 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -1648,8 +1648,6 @@  static int loadvm_postcopy_handle_advise(MigrationIncomingState *mis,
         return -1;
     }
 
-    postcopy_state_set(POSTCOPY_INCOMING_ADVISE);
-
     return 0;
 }