[v1] drm/modes: Don't apply cmdline's rotation if it wasn't specified
diff mbox series

Message ID 20190711021313.29445-1-digetx@gmail.com
State New
Headers show
Series
  • [v1] drm/modes: Don't apply cmdline's rotation if it wasn't specified
Related show

Commit Message

Dmitry Osipenko July 11, 2019, 2:13 a.m. UTC
The rotation mode from cmdline shouldn't be taken into account if it
wasn't specified in the cmdline. This fixes ignored default display
orientation when display mode is given using cmdline without the
rotation being specified.

Fixes: 1bf4e09227c3 ("drm/modes: Allow to specify rotation and reflection on the commandline")
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/gpu/drm/drm_client_modeset.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Maxime Ripard July 12, 2019, 7:54 p.m. UTC | #1
On Thu, Jul 11, 2019 at 05:13:13AM +0300, Dmitry Osipenko wrote:
> The rotation mode from cmdline shouldn't be taken into account if it
> wasn't specified in the cmdline. This fixes ignored default display
> orientation when display mode is given using cmdline without the
> rotation being specified.
>
> Fixes: 1bf4e09227c3 ("drm/modes: Allow to specify rotation and reflection on the commandline")
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>

Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>

Thanks!
Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Dmitry Osipenko July 13, 2019, 6:57 p.m. UTC | #2
12.07.2019 22:54, Maxime Ripard пишет:
> On Thu, Jul 11, 2019 at 05:13:13AM +0300, Dmitry Osipenko wrote:
>> The rotation mode from cmdline shouldn't be taken into account if it
>> wasn't specified in the cmdline. This fixes ignored default display
>> orientation when display mode is given using cmdline without the
>> rotation being specified.
>>
>> Fixes: 1bf4e09227c3 ("drm/modes: Allow to specify rotation and reflection on the commandline")
>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> 
> Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
> 
> Thanks!
> Maxime

Thank you. Please note that I'm not a DRM maintainer, hence either you
should pick up and apply the patch by yourself or somebody else who has
the commit rights will have do that. I guess Thierry could also pick up
the patch into the Tegra's tree, but this patch is more DRM-generic.
Maxime Ripard July 16, 2019, 8:42 a.m. UTC | #3
On Sat, Jul 13, 2019 at 09:57:32PM +0300, Dmitry Osipenko wrote:
> 12.07.2019 22:54, Maxime Ripard пишет:
> > On Thu, Jul 11, 2019 at 05:13:13AM +0300, Dmitry Osipenko wrote:
> >> The rotation mode from cmdline shouldn't be taken into account if it
> >> wasn't specified in the cmdline. This fixes ignored default display
> >> orientation when display mode is given using cmdline without the
> >> rotation being specified.
> >>
> >> Fixes: 1bf4e09227c3 ("drm/modes: Allow to specify rotation and reflection on the commandline")
> >> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> >
> > Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
> >
> > Thanks!
> > Maxime
>
> Thank you. Please note that I'm not a DRM maintainer, hence either you
> should pick up and apply the patch by yourself or somebody else who has
> the commit rights will have do that. I guess Thierry could also pick up
> the patch into the Tegra's tree, but this patch is more DRM-generic.

Right, I've applied it now

Thanks!
Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Dmitry Osipenko July 16, 2019, 2:02 p.m. UTC | #4
16.07.2019 11:42, Maxime Ripard пишет:
> On Sat, Jul 13, 2019 at 09:57:32PM +0300, Dmitry Osipenko wrote:
>> 12.07.2019 22:54, Maxime Ripard пишет:
>>> On Thu, Jul 11, 2019 at 05:13:13AM +0300, Dmitry Osipenko wrote:
>>>> The rotation mode from cmdline shouldn't be taken into account if it
>>>> wasn't specified in the cmdline. This fixes ignored default display
>>>> orientation when display mode is given using cmdline without the
>>>> rotation being specified.
>>>>
>>>> Fixes: 1bf4e09227c3 ("drm/modes: Allow to specify rotation and reflection on the commandline")
>>>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>>>
>>> Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
>>>
>>> Thanks!
>>> Maxime
>>
>> Thank you. Please note that I'm not a DRM maintainer, hence either you
>> should pick up and apply the patch by yourself or somebody else who has
>> the commit rights will have do that. I guess Thierry could also pick up
>> the patch into the Tegra's tree, but this patch is more DRM-generic.
> 
> Right, I've applied it now

Thank you very much!

Patch
diff mbox series

diff --git a/drivers/gpu/drm/drm_client_modeset.c b/drivers/gpu/drm/drm_client_modeset.c
index 56d36779d213..c8922b7cac09 100644
--- a/drivers/gpu/drm/drm_client_modeset.c
+++ b/drivers/gpu/drm/drm_client_modeset.c
@@ -859,7 +859,7 @@  bool drm_client_rotation(struct drm_mode_set *modeset, unsigned int *rotation)
 	 * simple XOR between the two handle the addition nicely.
 	 */
 	cmdline = &connector->cmdline_mode;
-	if (cmdline->specified) {
+	if (cmdline->specified && cmdline->rotation_reflection) {
 		unsigned int cmdline_rest, panel_rest;
 		unsigned int cmdline_rot, panel_rot;
 		unsigned int sum_rot, sum_rest;