[PATCHv2,1/3] zram/zram_lib.sh: fix variable name and algorithm retrieval
diff mbox series

Message ID 20190710072305.25806-2-po-hsu.lin@canonical.com
State New
Headers show
  • zram/zram_lib.sh: fix zram_compress_alg() test for zram01
Related show

Commit Message

Po-Hsu Lin July 10, 2019, 7:23 a.m. UTC
The compression algorithm was stored into a local variable "algs",
however the variable name zram_algs was used in the for loop later.

Unify them with algs so the default zram_algs defined in zram01 won't
be altered.

Also, use sed to get rid of the square brackets that indicates the
compression algorithm currently in use.
    $ cat /sys/block/zram0/comp_algorithm
    [lzo] lz4 lz4hc 842 zstd

Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
 testcases/kernel/device-drivers/zram/zram_lib.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff mbox series

diff --git a/testcases/kernel/device-drivers/zram/zram_lib.sh b/testcases/kernel/device-drivers/zram/zram_lib.sh
index d0e7704a8..599e5f0f3 100755
--- a/testcases/kernel/device-drivers/zram/zram_lib.sh
+++ b/testcases/kernel/device-drivers/zram/zram_lib.sh
@@ -98,10 +98,10 @@  zram_compress_alg()
 	tst_resm TINFO "test that we can set compression algorithm"
-	local algs="$(cat /sys/block/zram0/comp_algorithm)"
+	local algs="$(sed 's/[][]//g' /sys/block/zram0/comp_algorithm)"
 	tst_resm TINFO "supported algs: $algs"
 	local i=0
-	for alg in $zram_algs; do
+	for alg in $algs; do
 		local sys_path="/sys/block/zram${i}/comp_algorithm"
 		echo "$alg" >  $sys_path || \
 			tst_brkm TFAIL "can't set '$alg' to $sys_path"