[ovs-dev,1/2] ovn-performance.at: Missing steps for connecting LS to LR.
diff mbox series

Message ID 1562732591-47881-1-git-send-email-hzhou8@ebay.com
State New
Headers show
Series
  • [ovs-dev,1/2] ovn-performance.at: Missing steps for connecting LS to LR.
Related show

Commit Message

Han Zhou July 10, 2019, 4:23 a.m. UTC
From: Han Zhou <hzhou8@ebay.com>

The test creates 2 logical switches and connect them with a logical router.
However, it didn't set the option "router-port", so the 2 LS datapaths
were not connected. This results in missing test coverage for port-binding
incremental processing: assume I-P has a bug and port-binding change always
trigger recompute, since each HV monitors only its own datapath (i.e.
HV1 -> ls1, HV2 -> ls2) then it never got notification of the other
port-binding change, thus recompute is never triggered when port-binding
is updated on the other datapath. With this fix, each HV's local datapaths
will include both ls1 and ls2, so port-binding change notification will
be received properly and unexpected recompute would be captured.

Signed-off-by: Han Zhou <hzhou8@ebay.com>
---
 tests/ovn-performance.at | 4 ++++
 1 file changed, 4 insertions(+)

Patch
diff mbox series

diff --git a/tests/ovn-performance.at b/tests/ovn-performance.at
index 6a213eb..5e061ee 100644
--- a/tests/ovn-performance.at
+++ b/tests/ovn-performance.at
@@ -275,6 +275,10 @@  for i in 1 2; do
     )
     OVN_CONTROLLER_EXPECT_HIT(
         [hv1 hv2], [lflow_run],
+        [ovn-nbctl --wait=hv lsp-set-options $lsp router-port=$lrp]
+    )
+    OVN_CONTROLLER_EXPECT_HIT(
+        [hv1 hv2], [lflow_run],
         [ovn-nbctl --wait=hv lsp-set-addresses $lsp router]
     )
 done