mtd: rawnand: tango: Add of_node_put() before return
diff mbox series

Message ID 20190709171316.13451-1-nishkadg.linux@gmail.com
State Accepted
Delegated to: Miquel Raynal
Headers show
Series
  • mtd: rawnand: tango: Add of_node_put() before return
Related show

Commit Message

Nishka Dasgupta July 9, 2019, 5:13 p.m. UTC
Each iteration of for_each_child_of_node puts the previous node, but in
the case of a return from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the return.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
---
 drivers/mtd/nand/raw/tango_nand.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Mans Rullgard July 9, 2019, 6:42 p.m. UTC | #1
Nishka Dasgupta <nishkadg.linux@gmail.com> writes:

> Each iteration of for_each_child_of_node puts the previous node, but in
> the case of a return from the middle of the loop, there is no put, thus
> causing a memory leak. Hence add an of_node_put before the return.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
> ---
>  drivers/mtd/nand/raw/tango_nand.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/raw/tango_nand.c b/drivers/mtd/nand/raw/tango_nand.c
> index b3f2cabcc7c0..9acf2de37ee0 100644
> --- a/drivers/mtd/nand/raw/tango_nand.c
> +++ b/drivers/mtd/nand/raw/tango_nand.c
> @@ -659,6 +659,7 @@ static int tango_nand_probe(struct platform_device *pdev)
>  		err = chip_init(&pdev->dev, np);
>  		if (err) {
>  			tango_nand_remove(pdev);
> +			of_node_put(np);
>  			return err;
>  		}
>  	}
> -- 

Acked-by: Mans Rullgard <mans@mansr.com>
Miquel Raynal July 25, 2019, 7:55 a.m. UTC | #2
On Tue, 2019-07-09 at 17:13:16 UTC, Nishka Dasgupta wrote:
> Each iteration of for_each_child_of_node puts the previous node, but in
> the case of a return from the middle of the loop, there is no put, thus
> causing a memory leak. Hence add an of_node_put before the return.
> Issue found with Coccinelle.
> 
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
> Acked-by: Mans Rullgard <mans@mansr.com>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel

Patch
diff mbox series

diff --git a/drivers/mtd/nand/raw/tango_nand.c b/drivers/mtd/nand/raw/tango_nand.c
index b3f2cabcc7c0..9acf2de37ee0 100644
--- a/drivers/mtd/nand/raw/tango_nand.c
+++ b/drivers/mtd/nand/raw/tango_nand.c
@@ -659,6 +659,7 @@  static int tango_nand_probe(struct platform_device *pdev)
 		err = chip_init(&pdev->dev, np);
 		if (err) {
 			tango_nand_remove(pdev);
+			of_node_put(np);
 			return err;
 		}
 	}