Patchwork pkt_sched: fix sparse warning

login
register
mail settings
Submitter Hannes Eder
Date Nov. 27, 2008, 7:33 p.m.
Message ID <492fbbfd.190c660a.1db3.fffffcc3@mx.google.com>
Download mbox | patch
Permalink /patch/11299/
State Accepted
Delegated to: David Miller
Headers show

Comments

Hannes Eder - Nov. 27, 2008, 7:33 p.m.
Impact: make global function static

Fix the following sparse warning:

  net/sched/sch_api.c:192:14: warning: symbol 'qdisc_match_from_root' was not declared. Should it be static?

Signed-off-by: Hannes Eder <hannes@hanneseder.net>
---
 net/sched/sch_api.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
David Miller - Nov. 28, 2008, 11:07 a.m.
From: Hannes Eder <hannes@hanneseder.net>
Date: Thu, 27 Nov 2008 20:33:17 +0100

> Impact: make global function static
> 
> Fix the following sparse warning:
> 
>   net/sched/sch_api.c:192:14: warning: symbol 'qdisc_match_from_root' was not declared. Should it be static?
> 
> Signed-off-by: Hannes Eder <hannes@hanneseder.net>

Applied, thanks Hannes.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c
index f859dd5..6bc29e8 100644
--- a/net/sched/sch_api.c
+++ b/net/sched/sch_api.c
@@ -189,7 +189,7 @@  EXPORT_SYMBOL(unregister_qdisc);
    (root qdisc, all its children, children of children etc.)
  */
 
-struct Qdisc *qdisc_match_from_root(struct Qdisc *root, u32 handle)
+static struct Qdisc *qdisc_match_from_root(struct Qdisc *root, u32 handle)
 {
 	struct Qdisc *q;