| Message ID | 1562677762-24067-2-git-send-email-qii.wang@mediatek.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add MediaTek I3C master controller driver | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Tue, Jul 09, 2019 at 09:09:21PM +0800, Qii Wang wrote: > Document MediaTek I3C master DT bindings. > > Signed-off-by: Qii Wang <qii.wang@mediatek.com> > --- > .../devicetree/bindings/i3c/mtk,i3c-master.txt | 48 ++++++++++++++++++++ > 1 file changed, 48 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i3c/mtk,i3c-master.txt > > diff --git a/Documentation/devicetree/bindings/i3c/mtk,i3c-master.txt b/Documentation/devicetree/bindings/i3c/mtk,i3c-master.txt > new file mode 100644 > index 0000000..d32eda6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/i3c/mtk,i3c-master.txt > @@ -0,0 +1,48 @@ > +Bindings for MediaTek I3C master block > +===================================== > + > +Required properties: > +-------------------- > +- compatible: shall be "mediatek,i3c-master" Needs to be SoC specific. > +- reg: physical base address of the controller and apdma base, length of > + memory mapped region. > +- reg-names: shall be "main" for master controller and "dma" for apdma. > +- interrupts: the interrupt line connected to this I3C master. > +- clocks: shall reference the i3c and apdma clocks. > +- clock-names: shall include "main" and "dma". > + > +Mandatory properties defined by the generic binding (see > +Documentation/devicetree/bindings/i3c/i3c.txt for more details): > + > +- #address-cells: shall be set to 3 > +- #size-cells: shall be set to 0 > + > +Optional properties defined by the generic binding (see > +Documentation/devicetree/bindings/i3c/i3c.txt for more details): > + > +- i2c-scl-hz > +- i3c-scl-hz > + > +I3C device connected on the bus follow the generic description (see > +Documentation/devicetree/bindings/i3c/i3c.txt for more details). > + > +Example: > + > + i3c0: i3c@1100d000 { > + compatible = "mediatek,i3c-master"; > + reg = <0x1100d000 0x1000>, > + <0x11000300 0x80>; > + reg-names = "main", "dma"; > + interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_LOW>; > + clocks = <&infracfg CLK_INFRA_I3C0>, > + <&infracfg CLK_INFRA_AP_DMA>; > + clock-names = "main", "dma"; > + #address-cells = <3>; > + #size-cells = <0>; > + i2c-scl-hz = <100000>; > + > + nunchuk: nunchuk@52 { > + compatible = "nintendo,nunchuk"; > + reg = <0x52 0x0 0x10>; > + }; > + }; > -- > 1.7.9.5 >
On Wed, 2019-07-24 at 14:21 -0600, Rob Herring wrote: > On Tue, Jul 09, 2019 at 09:09:21PM +0800, Qii Wang wrote: > > Document MediaTek I3C master DT bindings. > > > > Signed-off-by: Qii Wang <qii.wang@mediatek.com> > > --- > > .../devicetree/bindings/i3c/mtk,i3c-master.txt | 48 ++++++++++++++++++++ > > 1 file changed, 48 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/i3c/mtk,i3c-master.txt > > > > diff --git a/Documentation/devicetree/bindings/i3c/mtk,i3c-master.txt b/Documentation/devicetree/bindings/i3c/mtk,i3c-master.txt > > new file mode 100644 > > index 0000000..d32eda6 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/i3c/mtk,i3c-master.txt > > @@ -0,0 +1,48 @@ > > +Bindings for MediaTek I3C master block > > +===================================== > > + > > +Required properties: > > +-------------------- > > +- compatible: shall be "mediatek,i3c-master" > > Needs to be SoC specific. > We hope that the SOCs will use the same driver and try to avoid big changes. If there are inevitable changes in the future, then we will modify the compatible to be SoC specific. cdns,i3c-master.txt is not SoC specific either. > > +- reg: physical base address of the controller and apdma base, length of > > + memory mapped region. > > +- reg-names: shall be "main" for master controller and "dma" for apdma. > > +- interrupts: the interrupt line connected to this I3C master. > > +- clocks: shall reference the i3c and apdma clocks. > > +- clock-names: shall include "main" and "dma". > > + > > +Mandatory properties defined by the generic binding (see > > +Documentation/devicetree/bindings/i3c/i3c.txt for more details): > > + > > +- #address-cells: shall be set to 3 > > +- #size-cells: shall be set to 0 > > + > > +Optional properties defined by the generic binding (see > > +Documentation/devicetree/bindings/i3c/i3c.txt for more details): > > + > > +- i2c-scl-hz > > +- i3c-scl-hz > > + > > +I3C device connected on the bus follow the generic description (see > > +Documentation/devicetree/bindings/i3c/i3c.txt for more details). > > + > > +Example: > > + > > + i3c0: i3c@1100d000 { > > + compatible = "mediatek,i3c-master"; > > + reg = <0x1100d000 0x1000>, > > + <0x11000300 0x80>; > > + reg-names = "main", "dma"; > > + interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_LOW>; > > + clocks = <&infracfg CLK_INFRA_I3C0>, > > + <&infracfg CLK_INFRA_AP_DMA>; > > + clock-names = "main", "dma"; > > + #address-cells = <3>; > > + #size-cells = <0>; > > + i2c-scl-hz = <100000>; > > + > > + nunchuk: nunchuk@52 { > > + compatible = "nintendo,nunchuk"; > > + reg = <0x52 0x0 0x10>; > > + }; > > + }; > > -- > > 1.7.9.5 > >
On Sat, 27 Jul 2019 09:23:33 +0800 Qii Wang <qii.wang@mediatek.com> wrote: > On Wed, 2019-07-24 at 14:21 -0600, Rob Herring wrote: > > On Tue, Jul 09, 2019 at 09:09:21PM +0800, Qii Wang wrote: > > > Document MediaTek I3C master DT bindings. > > > > > > Signed-off-by: Qii Wang <qii.wang@mediatek.com> > > > --- > > > .../devicetree/bindings/i3c/mtk,i3c-master.txt | 48 ++++++++++++++++++++ > > > 1 file changed, 48 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/i3c/mtk,i3c-master.txt > > > > > > diff --git a/Documentation/devicetree/bindings/i3c/mtk,i3c-master.txt b/Documentation/devicetree/bindings/i3c/mtk,i3c-master.txt > > > new file mode 100644 > > > index 0000000..d32eda6 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/i3c/mtk,i3c-master.txt > > > @@ -0,0 +1,48 @@ > > > +Bindings for MediaTek I3C master block > > > +===================================== > > > + > > > +Required properties: > > > +-------------------- > > > +- compatible: shall be "mediatek,i3c-master" > > > > Needs to be SoC specific. > > > > We hope that the SOCs will use the same driver and try to avoid big > changes. If there are inevitable changes in the future, then we will > modify the compatible to be SoC specific. cdns,i3c-master.txt is not SoC > specific either. The cadence case is a bit different I think. When the driver was developed there was no SoC integrating this IP. I guess Mediatek knows already which SoC(s) will embed the I3C master block. > > > > +- reg: physical base address of the controller and apdma base, length of > > > + memory mapped region. > > > +- reg-names: shall be "main" for master controller and "dma" for apdma. > > > +- interrupts: the interrupt line connected to this I3C master. > > > +- clocks: shall reference the i3c and apdma clocks. > > > +- clock-names: shall include "main" and "dma". > > > + > > > +Mandatory properties defined by the generic binding (see > > > +Documentation/devicetree/bindings/i3c/i3c.txt for more details): > > > + > > > +- #address-cells: shall be set to 3 > > > +- #size-cells: shall be set to 0 > > > + > > > +Optional properties defined by the generic binding (see > > > +Documentation/devicetree/bindings/i3c/i3c.txt for more details): > > > + > > > +- i2c-scl-hz > > > +- i3c-scl-hz > > > + > > > +I3C device connected on the bus follow the generic description (see > > > +Documentation/devicetree/bindings/i3c/i3c.txt for more details). > > > + > > > +Example: > > > + > > > + i3c0: i3c@1100d000 { > > > + compatible = "mediatek,i3c-master"; > > > + reg = <0x1100d000 0x1000>, > > > + <0x11000300 0x80>; > > > + reg-names = "main", "dma"; > > > + interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_LOW>; > > > + clocks = <&infracfg CLK_INFRA_I3C0>, > > > + <&infracfg CLK_INFRA_AP_DMA>; > > > + clock-names = "main", "dma"; > > > + #address-cells = <3>; > > > + #size-cells = <0>; > > > + i2c-scl-hz = <100000>; > > > + > > > + nunchuk: nunchuk@52 { > > > + compatible = "nintendo,nunchuk"; > > > + reg = <0x52 0x0 0x10>; > > > + }; > > > + }; > > > -- > > > 1.7.9.5 > > > > >
On Sat, 2019-07-27 at 11:18 +0200, Boris Brezillon wrote: > On Sat, 27 Jul 2019 09:23:33 +0800 > Qii Wang <qii.wang@mediatek.com> wrote: > > > On Wed, 2019-07-24 at 14:21 -0600, Rob Herring wrote: > > > On Tue, Jul 09, 2019 at 09:09:21PM +0800, Qii Wang wrote: > > > > Document MediaTek I3C master DT bindings. > > > > > > > > Signed-off-by: Qii Wang <qii.wang@mediatek.com> > > > > --- > > > > .../devicetree/bindings/i3c/mtk,i3c-master.txt | 48 ++++++++++++++++++++ > > > > 1 file changed, 48 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/i3c/mtk,i3c-master.txt > > > > > > > > diff --git a/Documentation/devicetree/bindings/i3c/mtk,i3c-master.txt b/Documentation/devicetree/bindings/i3c/mtk,i3c-master.txt > > > > new file mode 100644 > > > > index 0000000..d32eda6 > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/i3c/mtk,i3c-master.txt > > > > @@ -0,0 +1,48 @@ > > > > +Bindings for MediaTek I3C master block > > > > +===================================== > > > > + > > > > +Required properties: > > > > +-------------------- > > > > +- compatible: shall be "mediatek,i3c-master" > > > > > > Needs to be SoC specific. > > > > > > > We hope that the SOCs will use the same driver and try to avoid big > > changes. If there are inevitable changes in the future, then we will > > modify the compatible to be SoC specific. cdns,i3c-master.txt is not SoC > > specific either. > > The cadence case is a bit different I think. When the driver was > developed there was no SoC integrating this IP. I guess Mediatek knows > already which SoC(s) will embed the I3C master block. > ok, I will modify it as "mediatek,mt8183-i3c". > > > > > > +- reg: physical base address of the controller and apdma base, length of > > > > + memory mapped region. > > > > +- reg-names: shall be "main" for master controller and "dma" for apdma. > > > > +- interrupts: the interrupt line connected to this I3C master. > > > > +- clocks: shall reference the i3c and apdma clocks. > > > > +- clock-names: shall include "main" and "dma". > > > > + > > > > +Mandatory properties defined by the generic binding (see > > > > +Documentation/devicetree/bindings/i3c/i3c.txt for more details): > > > > + > > > > +- #address-cells: shall be set to 3 > > > > +- #size-cells: shall be set to 0 > > > > + > > > > +Optional properties defined by the generic binding (see > > > > +Documentation/devicetree/bindings/i3c/i3c.txt for more details): > > > > + > > > > +- i2c-scl-hz > > > > +- i3c-scl-hz > > > > + > > > > +I3C device connected on the bus follow the generic description (see > > > > +Documentation/devicetree/bindings/i3c/i3c.txt for more details). > > > > + > > > > +Example: > > > > + > > > > + i3c0: i3c@1100d000 { > > > > + compatible = "mediatek,i3c-master"; > > > > + reg = <0x1100d000 0x1000>, > > > > + <0x11000300 0x80>; > > > > + reg-names = "main", "dma"; > > > > + interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_LOW>; > > > > + clocks = <&infracfg CLK_INFRA_I3C0>, > > > > + <&infracfg CLK_INFRA_AP_DMA>; > > > > + clock-names = "main", "dma"; > > > > + #address-cells = <3>; > > > > + #size-cells = <0>; > > > > + i2c-scl-hz = <100000>; > > > > + > > > > + nunchuk: nunchuk@52 { > > > > + compatible = "nintendo,nunchuk"; > > > > + reg = <0x52 0x0 0x10>; > > > > + }; > > > > + }; > > > > -- > > > > 1.7.9.5 > > > > > > > > >
diff --git a/Documentation/devicetree/bindings/i3c/mtk,i3c-master.txt b/Documentation/devicetree/bindings/i3c/mtk,i3c-master.txt new file mode 100644 index 0000000..d32eda6 --- /dev/null +++ b/Documentation/devicetree/bindings/i3c/mtk,i3c-master.txt @@ -0,0 +1,48 @@ +Bindings for MediaTek I3C master block +===================================== + +Required properties: +-------------------- +- compatible: shall be "mediatek,i3c-master" +- reg: physical base address of the controller and apdma base, length of + memory mapped region. +- reg-names: shall be "main" for master controller and "dma" for apdma. +- interrupts: the interrupt line connected to this I3C master. +- clocks: shall reference the i3c and apdma clocks. +- clock-names: shall include "main" and "dma". + +Mandatory properties defined by the generic binding (see +Documentation/devicetree/bindings/i3c/i3c.txt for more details): + +- #address-cells: shall be set to 3 +- #size-cells: shall be set to 0 + +Optional properties defined by the generic binding (see +Documentation/devicetree/bindings/i3c/i3c.txt for more details): + +- i2c-scl-hz +- i3c-scl-hz + +I3C device connected on the bus follow the generic description (see +Documentation/devicetree/bindings/i3c/i3c.txt for more details). + +Example: + + i3c0: i3c@1100d000 { + compatible = "mediatek,i3c-master"; + reg = <0x1100d000 0x1000>, + <0x11000300 0x80>; + reg-names = "main", "dma"; + interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_LOW>; + clocks = <&infracfg CLK_INFRA_I3C0>, + <&infracfg CLK_INFRA_AP_DMA>; + clock-names = "main", "dma"; + #address-cells = <3>; + #size-cells = <0>; + i2c-scl-hz = <100000>; + + nunchuk: nunchuk@52 { + compatible = "nintendo,nunchuk"; + reg = <0x52 0x0 0x10>; + }; + };
Document MediaTek I3C master DT bindings. Signed-off-by: Qii Wang <qii.wang@mediatek.com> --- .../devicetree/bindings/i3c/mtk,i3c-master.txt | 48 ++++++++++++++++++++ 1 file changed, 48 insertions(+) create mode 100644 Documentation/devicetree/bindings/i3c/mtk,i3c-master.txt