Message ID | 20190708192459.187984-7-mka@chromium.org |
---|---|
State | Changes Requested, archived |
Headers | show |
Series | net: phy: realtek: Enable configuration of RTL8211E LEDs and SSC | expand |
Context | Check | Description |
---|---|---|
robh/checkpatch | success |
On Mon, Jul 08, 2019 at 12:24:58PM -0700, Matthias Kaehlcke wrote: > The LED behavior of some Realtek PHYs is configurable. Add the > property 'realtek,led-modes' to specify the configuration of the > LEDs. > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> Hi Matthias Humm. I thought you were going to drop this and the next patch? Andrew
Hi Andrew, On Mon, Jul 08, 2019 at 09:48:34PM +0200, Andrew Lunn wrote: > On Mon, Jul 08, 2019 at 12:24:58PM -0700, Matthias Kaehlcke wrote: > > The LED behavior of some Realtek PHYs is configurable. Add the > > property 'realtek,led-modes' to specify the configuration of the > > LEDs. > > > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > > Hi Matthias > > Humm. I thought you were going to drop this and the next patch? It wasn't clear to me whether not introducing a generic interface is a definitive NACK and tought I could at least post a version with the review comments addressed. If there is no way forward without a generic interface I'll drop the two patches.
diff --git a/Documentation/devicetree/bindings/net/realtek.txt b/Documentation/devicetree/bindings/net/realtek.txt index af2824664f08..ab218f2b7653 100644 --- a/Documentation/devicetree/bindings/net/realtek.txt +++ b/Documentation/devicetree/bindings/net/realtek.txt @@ -19,6 +19,14 @@ Optional properties: Only supported for "realtek,rtl8211e". +- realtek,led-modes: LED mode configuration. + + A 0..3 element vector, with each element configuring the operating + mode of an LED. Omitted LEDs are turned off. Allowed values are + defined in "include/dt-bindings/net/realtek.h". + + Only supported for "realtek,rtl8211e". + Example: @@ -32,5 +40,8 @@ mdio0 { reg = <1>; realtek,eee-led-mode-disable; realtek,enable-ssc; + realtek,led-modes = <RTL8211E_LINK_ACTIVITY + RTL8211E_LINK_100 + RTL8211E_LINK_1000>; }; }; diff --git a/include/dt-bindings/net/realtek.h b/include/dt-bindings/net/realtek.h new file mode 100644 index 000000000000..023cb776a7a3 --- /dev/null +++ b/include/dt-bindings/net/realtek.h @@ -0,0 +1,18 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _DT_BINDINGS_REALTEK_H +#define _DT_BINDINGS_REALTEK_H + +/* LED modes for RTL8211E PHY */ + +#define RTL8211E_LED_OFF 0 +#define RTL8211E_LINK_10 1 +#define RTL8211E_LINK_100 2 +#define RTL8211E_LINK_1000 4 +#define RTL8211E_LINK_10_100 3 +#define RTL8211E_LINK_10_1000 5 +#define RTL8211E_LINK_100_1000 6 +#define RTL8211E_LINK_10_100_1000 7 + +#define RTL8211E_LINK_ACTIVITY (1 << 16) + +#endif
The LED behavior of some Realtek PHYs is configurable. Add the property 'realtek,led-modes' to specify the configuration of the LEDs. Signed-off-by: Matthias Kaehlcke <mka@chromium.org> --- Changes in v3: - added RTL8211E_LED_OFF to LED modes - changed wording for supported PHY models Changes in v2: - patch added to the series --- .../devicetree/bindings/net/realtek.txt | 11 +++++++++++ include/dt-bindings/net/realtek.h | 18 ++++++++++++++++++ 2 files changed, 29 insertions(+) create mode 100644 include/dt-bindings/net/realtek.h