rtc: bd70528: add dependency to fix build errors
diff mbox series

Message ID 420b921d-10ca-1d9a-ac46-5969a7f0e0b9@infradead.org
State Changes Requested
Headers show
Series
  • rtc: bd70528: add dependency to fix build errors
Related show

Commit Message

Randy Dunlap July 7, 2019, 4:12 p.m. UTC
From: Randy Dunlap <rdunlap@infradead.org>

Fix build errors when MFD_ROHM_BD70528=m, BD70528_WATCHDOG=m,
and RTC_DRV_BD70528=y.  Fixes these build errors:

ld: drivers/rtc/rtc-bd70528.o: in function `bd70528_alm_enable':
rtc-bd70528.c:(.text+0x3a2): undefined reference to `bd70528_wdt_lock'
ld: rtc-bd70528.c:(.text+0x3f8): undefined reference to `bd70528_wdt_unlock'
ld: drivers/rtc/rtc-bd70528.o: in function `bd70528_set_rtc_based_timers':
rtc-bd70528.c:(.text+0x41c): undefined reference to `bd70528_wdt_set'
ld: drivers/rtc/rtc-bd70528.o: in function `bd70528_set_time':
rtc-bd70528.c:(.text+0x500): undefined reference to `bd70528_wdt_lock'
ld: rtc-bd70528.c:(.text+0x587): undefined reference to `bd70528_wdt_unlock'

Also add a blank line to separate the Kconfig entry from the one
above it.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: linux-rtc@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>
---
Found in mmotm but applies to linux-next.

 drivers/rtc/Kconfig |    2 ++
 1 file changed, 2 insertions(+)

Comments

Vaittinen, Matti July 8, 2019, 1:29 p.m. UTC | #1
Hello Randy,

Thanks a lot for trying to clean up the mess :)

On Sun, 2019-07-07 at 09:12 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix build errors when MFD_ROHM_BD70528=m, BD70528_WATCHDOG=m,
> and RTC_DRV_BD70528=y.  Fixes these build errors:
> 
> ld: drivers/rtc/rtc-bd70528.o: in function `bd70528_alm_enable':
> rtc-bd70528.c:(.text+0x3a2): undefined reference to
> `bd70528_wdt_lock'
> ld: rtc-bd70528.c:(.text+0x3f8): undefined reference to
> `bd70528_wdt_unlock'
> ld: drivers/rtc/rtc-bd70528.o: in function
> `bd70528_set_rtc_based_timers':
> rtc-bd70528.c:(.text+0x41c): undefined reference to `bd70528_wdt_set'
> ld: drivers/rtc/rtc-bd70528.o: in function `bd70528_set_time':
> rtc-bd70528.c:(.text+0x500): undefined reference to
> `bd70528_wdt_lock'
> ld: rtc-bd70528.c:(.text+0x587): undefined reference to
> `bd70528_wdt_unlock'
> 
> Also add a blank line to separate the Kconfig entry from the one
> above it.
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> Cc: linux-rtc@vger.kernel.org
> Cc: Andrew Morton <akpm@linux-foundation.org>
> ---
> Found in mmotm but applies to linux-next.
> 
>  drivers/rtc/Kconfig |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- mmotm-2019-0706-2200.orig/drivers/rtc/Kconfig
> +++ mmotm-2019-0706-2200/drivers/rtc/Kconfig
> @@ -498,8 +498,10 @@ config RTC_DRV_M41T80_WDT
>  	help
>  	  If you say Y here you will get support for the
>  	  watchdog timer in the ST M41T60 and M41T80 RTC chips series.
> +
>  config RTC_DRV_BD70528
>  	tristate "ROHM BD70528 PMIC RTC"
> +	depends on MFD_ROHM_BD70528

This is definitely required dependency. But I guess this is still not
fixing everything... I assume this allows configuring MFD and RTC in-
kernel while leaving WDG to be built as module. That will probably also
fail. I am not sure how to solve this elegantly while still allowing
WDG to be left out if it is not needed.

>  	help
>  	  If you say Y here you will get support for the RTC
>  	  on ROHM BD70528 Power Management IC.
> 
> 

Br,
	Matti Vaittinen

Patch
diff mbox series

--- mmotm-2019-0706-2200.orig/drivers/rtc/Kconfig
+++ mmotm-2019-0706-2200/drivers/rtc/Kconfig
@@ -498,8 +498,10 @@  config RTC_DRV_M41T80_WDT
 	help
 	  If you say Y here you will get support for the
 	  watchdog timer in the ST M41T60 and M41T80 RTC chips series.
+
 config RTC_DRV_BD70528
 	tristate "ROHM BD70528 PMIC RTC"
+	depends on MFD_ROHM_BD70528
 	help
 	  If you say Y here you will get support for the RTC
 	  on ROHM BD70528 Power Management IC.