From patchwork Thu Sep 1 10:33:56 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 112857 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 39D17B6F68 for ; Thu, 1 Sep 2011 20:34:13 +1000 (EST) Received: (qmail 20216 invoked by alias); 1 Sep 2011 10:34:11 -0000 Received: (qmail 20104 invoked by uid 22791); 1 Sep 2011 10:34:11 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, TW_TM X-Spam-Check-By: sourceware.org Received: from mail-yw0-f47.google.com (HELO mail-yw0-f47.google.com) (209.85.213.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Sep 2011 10:33:57 +0000 Received: by ywa12 with SMTP id 12so1325121ywa.20 for ; Thu, 01 Sep 2011 03:33:56 -0700 (PDT) MIME-Version: 1.0 Received: by 10.150.69.3 with SMTP id r3mr46683yba.223.1314873236689; Thu, 01 Sep 2011 03:33:56 -0700 (PDT) Received: by 10.151.84.14 with HTTP; Thu, 1 Sep 2011 03:33:56 -0700 (PDT) In-Reply-To: <20110901093440.GA20263@adacore.com> References: <20110831111610.GA49689@adacore.com> <20110831150740.GC83109@adacore.com> <20110831155718.GB90456@adacore.com> <58487A02-7DE9-48DD-BAFB-D2DC4A61156B@sandoe-acoustics.co.uk> <20110831163434.GA95956@adacore.com> <20110901093440.GA20263@adacore.com> Date: Thu, 1 Sep 2011 12:33:56 +0200 Message-ID: Subject: Re: [Ada] Implementation of aspects within generic units From: Richard Guenther To: Arnaud Charlet Cc: Tom de Vries , Iain Sandoe , "Joseph S. Myers" , Eric Botcazou , Olivier Hainque , gcc-patches@gcc.gnu.org X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Thu, Sep 1, 2011 at 11:34 AM, Arnaud Charlet wrote: > After doing a binary search, the first revision which breaks bootstrap on > my environment with Ada enabled is the following: > > r178353 | vries | 2011-08-31 09:04:25 +0200 (Wed, 31 Aug 2011) | 8 lines > > 2011-08-31  Tom de Vries   > >        PR middle-end/43513 >        * Makefile.in (tree-ssa-ccp.o): Add $(PARAMS_H) to rule. >        * tree-ssa-ccp.c (params.h): Include. >        (fold_builtin_alloca_for_var): New function. >        (ccp_fold_stmt): Use fold_builtin_alloca_for_var. > > Which makes sense, since Ada uses alloca a lot, much more than other languages. > > In other words, none of the changes in the Ada repository is reponsible for > this regression. > > So Tom and/or Richard, could you please have a look at this regression? TIA. Probably worth checking should be reproducable with low stack ulimit. Richard. > Arno > Index: gcc/tree-ssa-ccp.c =================================================================== --- gcc/tree-ssa-ccp.c (revision 178394) +++ gcc/tree-ssa-ccp.c (working copy) @@ -1714,7 +1714,7 @@ fold_builtin_alloca_for_var (gimple stmt block = gimple_block (stmt); if (!(cfun->after_inlining && TREE_CODE (BLOCK_SUPERCONTEXT (block)) == FUNCTION_DECL)) - threshold /= 10; + return NULL_TREE; if (size > threshold) return NULL_TREE;