From patchwork Fri Jul 5 11:05:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 1128037 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="N1dPk49c"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=infradead.org header.i=@infradead.org header.b="NzyUrpSm"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45gGdh06VSz9sN4 for ; Fri, 5 Jul 2019 23:58:16 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=nNf7wsmHUVXrZUVureacPDskNVGI6bT15xScMptqulQ=; b=N1dPk49cAyrZ2a nXCUYYokU1sYh6xsU0YAn0g/ao1z7NtWUkftUlMJxpskQal+6422YGf4fIL21alJVbAB1CiCCtj3Y Gaa6alBevKmvCJTTq5CvlpFevRmm8YQkeCgcVRHFzmXGsysuzif5lkms4QB91gYD8P5KXL+96zYIj RhC1a2zubQ87jhKnJjhStUqlULcZ4kPQ8l6QORGM6qn+tEnMM4jBCPI63KVWJz31l6xpJqAA6TVJl GEOwag2sBkS0zih5qv3KdBHhPo3+A1l+d30gEPo7tsvD1b1P+QHFQB1ft2sDMYdyQxlZL5l84tv0m 2etvxL+634Qhia3AVuIw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hjOj7-00014T-EP; Fri, 05 Jul 2019 13:58:13 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hjM3P-0005PB-40 for linux-mtd@bombadil.infradead.org; Fri, 05 Jul 2019 11:06:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Q4SNChIUfnv28H4D7zgI5TGG3vbmr5daUepkM0Qm/7I=; b=NzyUrpSmRXPh053Kw/prbAQc4l +5kFyy0UdCaQHiCEIOn3w8L7GVa8t4COHg/18I9si0qEpyWOWK0ErcgjY1uHhcg9Uey+Oj16GhFFe eRLxE6HxoIEmlM171sasllzB0YXnbfZN5Ldczw84Bi63Yu28WhtNaIa6Q386sff2DsNYPBdVo3ckW 3bzyU6Qzgy8XiUZPahpHmKbG2nsJVuMp+aErcIjfonoZz+KHdmYvHLLvKJVI5HIxrYdGIo9Xq1EhL /QG2IFVYPqiQ30Q1VdNaoKoq9P0P7eRzFkTJenJJR/uj+keMHOJUjl1r8Ie8eeGt/36mal0QSJnri fqTeyynA==; Received: from youngberry.canonical.com ([91.189.89.112]) by casper.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hjM3L-0005Qb-H4 for linux-mtd@lists.infradead.org; Fri, 05 Jul 2019 11:06:57 +0000 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1hjM2B-0008LA-W0; Fri, 05 Jul 2019 11:05:44 +0000 From: Colin King To: Richard Weinberger , Artem Bityutskiy , Adrian Hunter , linux-mtd@lists.infradead.org Subject: [PATCH][V2] ubifs: remove redundant assignment to pointer fname Date: Fri, 5 Jul 2019 12:05:43 +0100 Message-Id: <20190705110543.31428-1-colin.king@canonical.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190705_120655_603540_8EC6367F X-CRM114-Status: GOOD ( 10.43 ) X-Spam-Score: -5.0 (-----) X-Spam-Report: SpamAssassin version 3.4.2 on casper.infradead.org summary: Content analysis details: (-5.0 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at https://www.dnswl.org/, high trust [91.189.89.112 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 SPF_NONE SPF: sender does not publish an SPF Record X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Colin Ian King The pointer fname is being assigned with a value that is never read because the function returns after the assignment. The assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- V2: fix up commit message --- fs/ubifs/debug.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c index 92fe5c5ed78a..95da71e13fc8 100644 --- a/fs/ubifs/debug.c +++ b/fs/ubifs/debug.c @@ -2817,7 +2817,6 @@ void dbg_debugfs_init_fs(struct ubifs_info *c) c->vi.ubi_num, c->vi.vol_id); if (n == UBIFS_DFS_DIR_LEN) { /* The array size is too small */ - fname = UBIFS_DFS_DIR_NAME; return; }