[1/2] cpu/msr: add document info the cpu_msr_map table
diff mbox series

Message ID 20190705012758.11151-1-alex.hung@canonical.com
State Accepted
Headers show
Series
  • [1/2] cpu/msr: add document info the cpu_msr_map table
Related show

Commit Message

Alex Hung July 5, 2019, 1:27 a.m. UTC
Adding comments only. There are no functional changes.

Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 src/cpu/msr/msr.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Ivan Hu July 24, 2019, 6:46 a.m. UTC | #1
On 7/5/19 9:27 AM, Alex Hung wrote:
> Adding comments only. There are no functional changes.
> 
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>   src/cpu/msr/msr.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/src/cpu/msr/msr.c b/src/cpu/msr/msr.c
> index 2cd51e5c..ea6ca207 100644
> --- a/src/cpu/msr/msr.c
> +++ b/src/cpu/msr/msr.c
> @@ -728,6 +728,10 @@ typedef struct {
>   	const msr_info *const info;
>   } cpu_to_msr;
>   
> +/*
> + * Intel's CPU-specific MSRs can be found in
> + * Intel® 64 and IA-32 ArchitecturesSoftware Developer’s Manual Volume 4
> + */
>   static const cpu_to_msr cpu_msr_map[] = {
>   	{ "Pentium",			0x05, 0x01,	NULL },
>   	{ "Pentium",			0x05, 0x02,	NULL },
> 

Acked-by: Ivan Hu <ivan.hu@canonical.com>
Colin King July 24, 2019, 3:02 p.m. UTC | #2
On 05/07/2019 02:27, Alex Hung wrote:
> Adding comments only. There are no functional changes.
> 
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/cpu/msr/msr.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/cpu/msr/msr.c b/src/cpu/msr/msr.c
> index 2cd51e5c..ea6ca207 100644
> --- a/src/cpu/msr/msr.c
> +++ b/src/cpu/msr/msr.c
> @@ -728,6 +728,10 @@ typedef struct {
>  	const msr_info *const info;
>  } cpu_to_msr;
>  
> +/*
> + * Intel's CPU-specific MSRs can be found in
> + * Intel® 64 and IA-32 ArchitecturesSoftware Developer’s Manual Volume 4
> + */
>  static const cpu_to_msr cpu_msr_map[] = {
>  	{ "Pentium",			0x05, 0x01,	NULL },
>  	{ "Pentium",			0x05, 0x02,	NULL },
> 
Acked-by: Colin Ian King <colin.king@canonical.com>

Patch
diff mbox series

diff --git a/src/cpu/msr/msr.c b/src/cpu/msr/msr.c
index 2cd51e5c..ea6ca207 100644
--- a/src/cpu/msr/msr.c
+++ b/src/cpu/msr/msr.c
@@ -728,6 +728,10 @@  typedef struct {
 	const msr_info *const info;
 } cpu_to_msr;
 
+/*
+ * Intel's CPU-specific MSRs can be found in
+ * Intel® 64 and IA-32 ArchitecturesSoftware Developer’s Manual Volume 4
+ */
 static const cpu_to_msr cpu_msr_map[] = {
 	{ "Pentium",			0x05, 0x01,	NULL },
 	{ "Pentium",			0x05, 0x02,	NULL },