[next] ubifs: remove redundant assignment to pointer fname
diff mbox series

Message ID 20190704222803.4328-1-colin.king@canonical.com
State New
Headers show
Series
  • [next] ubifs: remove redundant assignment to pointer fname
Related show

Commit Message

Colin Ian King July 4, 2019, 10:28 p.m. UTC
From: Colin Ian King <colin.king@canonical.com>

The pointer fname rc is being assigned with a value that is never
read because the function returns after the assignment. The assignment
is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 fs/ubifs/debug.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Sergei Shtylyov July 5, 2019, 8:24 a.m. UTC | #1
Hello!

On 05.07.2019 1:28, Colin King wrote:

> From: Colin Ian King <colin.king@canonical.com>
> 
> The pointer fname rc is being assigned with a value that is never

    rc?

> read because the function returns after the assignment. The assignment
> is redundant and can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   fs/ubifs/debug.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c
> index 92fe5c5ed78a..95da71e13fc8 100644
> --- a/fs/ubifs/debug.c
> +++ b/fs/ubifs/debug.c
> @@ -2817,7 +2817,6 @@ void dbg_debugfs_init_fs(struct ubifs_info *c)
>   		     c->vi.ubi_num, c->vi.vol_id);
>   	if (n == UBIFS_DFS_DIR_LEN) {
>   		/* The array size is too small */
> -		fname = UBIFS_DFS_DIR_NAME;
>   		return;
>   	}
>   

MBR, Sergei
Colin Ian King July 5, 2019, 8:31 a.m. UTC | #2
On 05/07/2019 09:24, Sergei Shtylyov wrote:
> Hello!
> 
> On 05.07.2019 1:28, Colin King wrote:
> 
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The pointer fname rc is being assigned with a value that is never
> 
>    rc?

Oops, cut'n'paste error. Do you want me to resend to can this be fixed
when it's applied?

Colin

> 
>> read because the function returns after the assignment. The assignment
>> is redundant and can be removed.
>>
>> Addresses-Coverity: ("Unused value")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>>   fs/ubifs/debug.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c
>> index 92fe5c5ed78a..95da71e13fc8 100644
>> --- a/fs/ubifs/debug.c
>> +++ b/fs/ubifs/debug.c
>> @@ -2817,7 +2817,6 @@ void dbg_debugfs_init_fs(struct ubifs_info *c)
>>                c->vi.ubi_num, c->vi.vol_id);
>>       if (n == UBIFS_DFS_DIR_LEN) {
>>           /* The array size is too small */
>> -        fname = UBIFS_DFS_DIR_NAME;
>>           return;
>>       }
>>   
> 
> MBR, Sergei
>
Sergei Shtylyov July 5, 2019, 10:51 a.m. UTC | #3
On 07/05/2019 11:31 AM, Colin Ian King wrote:

>>> From: Colin Ian King <colin.king@canonical.com>
>>>
>>> The pointer fname rc is being assigned with a value that is never
>>
>>    rc?
> 
> Oops, cut'n'paste error. Do you want me to resend to can this be fixed
> when it's applied?

   That's the question to the maintainers...

MBR, Sergei
Richard Weinberger July 5, 2019, 11:02 a.m. UTC | #4
----- Ursprüngliche Mail -----
> Von: "Sergei Shtylyov" <sergei.shtylyov@cogentembedded.com>
> An: "Colin Ian King" <colin.king@canonical.com>, "richard" <richard@nod.at>, "Artem Bityutskiy" <dedekind1@gmail.com>,
> "Adrian Hunter" <adrian.hunter@intel.com>, "linux-mtd" <linux-mtd@lists.infradead.org>
> CC: kernel-janitors@vger.kernel.org, "linux-kernel" <linux-kernel@vger.kernel.org>
> Gesendet: Freitag, 5. Juli 2019 12:51:53
> Betreff: Re: [PATCH][next] ubifs: remove redundant assignment to pointer fname

> On 07/05/2019 11:31 AM, Colin Ian King wrote:
> 
>>>> From: Colin Ian King <colin.king@canonical.com>
>>>>
>>>> The pointer fname rc is being assigned with a value that is never
>>>
>>>    rc?
>> 
>> Oops, cut'n'paste error. Do you want me to resend to can this be fixed
>> when it's applied?
> 
>   That's the question to the maintainers...

Please resend.

Thanks,
//richard

Patch
diff mbox series

diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c
index 92fe5c5ed78a..95da71e13fc8 100644
--- a/fs/ubifs/debug.c
+++ b/fs/ubifs/debug.c
@@ -2817,7 +2817,6 @@  void dbg_debugfs_init_fs(struct ubifs_info *c)
 		     c->vi.ubi_num, c->vi.vol_id);
 	if (n == UBIFS_DFS_DIR_LEN) {
 		/* The array size is too small */
-		fname = UBIFS_DFS_DIR_NAME;
 		return;
 	}