| Message ID | 20190704130239.24111-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v1] pinctrl: intel: Drop double check for data in intel_pinctrl_probe_by_uid() | expand |
On Thu, Jul 04, 2019 at 04:02:39PM +0300, Andy Shevchenko wrote: > There is no need to duplicate the check which is done in the common > intel_pinctrl_probe(). > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
On Thu, Jul 04, 2019 at 04:13:21PM +0300, Mika Westerberg wrote: > On Thu, Jul 04, 2019 at 04:02:39PM +0300, Andy Shevchenko wrote: > > There is no need to duplicate the check which is done in the common > > intel_pinctrl_probe(). > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com> Pushed to my review and testing queue, thanks!
diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c index a18d6eefe672..8014c95c649f 100644 --- a/drivers/pinctrl/intel/pinctrl-intel.c +++ b/drivers/pinctrl/intel/pinctrl-intel.c @@ -1421,8 +1421,6 @@ int intel_pinctrl_probe_by_uid(struct platform_device *pdev) table = (const struct intel_pinctrl_soc_data **)id->driver_data; data = table[pdev->id]; } - if (!data) - return -ENODEV; return intel_pinctrl_probe(pdev, data); }
There is no need to duplicate the check which is done in the common intel_pinctrl_probe(). Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/pinctrl/intel/pinctrl-intel.c | 2 -- 1 file changed, 2 deletions(-)