[ovs-dev,V2,1/1] netdev-vport: Make ip6gre netdev type to use TC rules
diff mbox series

Message ID 20190704073642.25346-1-elibr@mellanox.com
State Accepted
Headers show
Series
  • [ovs-dev,V2,1/1] netdev-vport: Make ip6gre netdev type to use TC rules
Related show

Commit Message

Eli Britstein July 4, 2019, 7:36 a.m. UTC
The offload api functions already assigned to every tunnel class.
For ip6gre tunnel class only need to also assign the get_ifindex
function, similarly as done in commit 5e63eaa969a3 ("netdev-vport: Make
gre netdev type to use TC rules").

Signed-off-by: Eli Britstein <elibr@mellanox.com>
Reviewed-by: Roi Dayan <roid@mellanox.com>
---
 lib/netdev-vport.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Roi Dayan July 11, 2019, 1:11 p.m. UTC | #1
On 2019-07-04 10:36 AM, Eli Britstein wrote:
> The offload api functions already assigned to every tunnel class.
> For ip6gre tunnel class only need to also assign the get_ifindex
> function, similarly as done in commit 5e63eaa969a3 ("netdev-vport: Make
> gre netdev type to use TC rules").
> 
> Signed-off-by: Eli Britstein <elibr@mellanox.com>
> Reviewed-by: Roi Dayan <roid@mellanox.com>
> ---
>  lib/netdev-vport.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c
> index 92a256af1..b57d21ff8 100644
> --- a/lib/netdev-vport.c
> +++ b/lib/netdev-vport.c
> @@ -1218,7 +1218,8 @@ netdev_vport_tunnel_register(void)
>                .type = "ip6gre",
>                .build_header = netdev_gre_build_header,
>                .push_header = netdev_gre_push_header,
> -              .pop_header = netdev_gre_pop_header
> +              .pop_header = netdev_gre_pop_header,
> +              .get_ifindex = NETDEV_VPORT_GET_IFINDEX,
>            },
>            {{NULL, NULL, 0, 0}}
>          },
> 

ping. can we merge this? 
thanks
Ben Pfaff July 12, 2019, 3:54 p.m. UTC | #2
On Thu, Jul 11, 2019 at 01:11:22PM +0000, Roi Dayan wrote:
> 
> 
> On 2019-07-04 10:36 AM, Eli Britstein wrote:
> > The offload api functions already assigned to every tunnel class.
> > For ip6gre tunnel class only need to also assign the get_ifindex
> > function, similarly as done in commit 5e63eaa969a3 ("netdev-vport: Make
> > gre netdev type to use TC rules").
> > 
> > Signed-off-by: Eli Britstein <elibr@mellanox.com>
> > Reviewed-by: Roi Dayan <roid@mellanox.com>
> > ---
> >  lib/netdev-vport.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c
> > index 92a256af1..b57d21ff8 100644
> > --- a/lib/netdev-vport.c
> > +++ b/lib/netdev-vport.c
> > @@ -1218,7 +1218,8 @@ netdev_vport_tunnel_register(void)
> >                .type = "ip6gre",
> >                .build_header = netdev_gre_build_header,
> >                .push_header = netdev_gre_push_header,
> > -              .pop_header = netdev_gre_pop_header
> > +              .pop_header = netdev_gre_pop_header,
> > +              .get_ifindex = NETDEV_VPORT_GET_IFINDEX,
> >            },
> >            {{NULL, NULL, 0, 0}}
> >          },
> > 
> 
> ping. can we merge this? 

Done.

Patch
diff mbox series

diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c
index 92a256af1..b57d21ff8 100644
--- a/lib/netdev-vport.c
+++ b/lib/netdev-vport.c
@@ -1218,7 +1218,8 @@  netdev_vport_tunnel_register(void)
               .type = "ip6gre",
               .build_header = netdev_gre_build_header,
               .push_header = netdev_gre_push_header,
-              .pop_header = netdev_gre_pop_header
+              .pop_header = netdev_gre_pop_header,
+              .get_ifindex = NETDEV_VPORT_GET_IFINDEX,
           },
           {{NULL, NULL, 0, 0}}
         },