[v1,1/4] pinctrl: baytrail: Use devm_platform_ioremap_resource()
diff mbox series

Message ID 20190703145615.74768-1-andriy.shevchenko@linux.intel.com
State New
Headers show
Series
  • [v1,1/4] pinctrl: baytrail: Use devm_platform_ioremap_resource()
Related show

Commit Message

Andy Shevchenko July 3, 2019, 2:56 p.m. UTC
Use the new helper that wraps the calls to platform_get_resource()
and devm_ioremap_resource() together.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/pinctrl/intel/pinctrl-baytrail.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Mika Westerberg July 3, 2019, 4:36 p.m. UTC | #1
On Wed, Jul 03, 2019 at 05:56:12PM +0300, Andy Shevchenko wrote:
> Use the new helper that wraps the calls to platform_get_resource()
> and devm_ioremap_resource() together.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

For the whole series,

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Andy Shevchenko July 23, 2019, 3:51 p.m. UTC | #2
On Wed, Jul 03, 2019 at 07:36:30PM +0300, Mika Westerberg wrote:
> On Wed, Jul 03, 2019 at 05:56:12PM +0300, Andy Shevchenko wrote:
> > Use the new helper that wraps the calls to platform_get_resource()
> > and devm_ioremap_resource() together.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> For the whole series,
> 
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Pushed to my review and testing queue, thanks!
Linus Walleij July 28, 2019, 10:06 p.m. UTC | #3
On Tue, Jul 23, 2019 at 5:51 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:

> Pushed to my review and testing queue, thanks!

I take it I can get a pull request with all the Intel pinctrl changes?
They all look good to me.

Yours,
Linus Walleij
Andy Shevchenko July 29, 2019, 9:37 a.m. UTC | #4
On Mon, Jul 29, 2019 at 12:06:52AM +0200, Linus Walleij wrote:
> On Tue, Jul 23, 2019 at 5:51 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> 
> > Pushed to my review and testing queue, thanks!
> 
> I take it I can get a pull request with all the Intel pinctrl changes?
> They all look good to me.

Yes, we are collecting them, and GPIO as well.
Linus Walleij July 29, 2019, 9:25 p.m. UTC | #5
On Mon, Jul 29, 2019 at 11:37 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> On Mon, Jul 29, 2019 at 12:06:52AM +0200, Linus Walleij wrote:
> > On Tue, Jul 23, 2019 at 5:51 PM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> >
> > > Pushed to my review and testing queue, thanks!
> >
> > I take it I can get a pull request with all the Intel pinctrl changes?
> > They all look good to me.
>
> Yes, we are collecting them, and GPIO as well.

Awesome, thanks a LOT!

Linus Walleij

Patch
diff mbox series

diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c
index bfde1c710bd9..4fc4f9658484 100644
--- a/drivers/pinctrl/intel/pinctrl-baytrail.c
+++ b/drivers/pinctrl/intel/pinctrl-baytrail.c
@@ -1582,12 +1582,10 @@  static int byt_set_soc_data(struct byt_gpio *vg,
 
 	for (i = 0; i < soc_data->ncommunities; i++) {
 		struct byt_community *comm = vg->communities_copy + i;
-		struct resource *mem_rc;
 
 		*comm = vg->soc_data->communities[i];
 
-		mem_rc = platform_get_resource(vg->pdev, IORESOURCE_MEM, 0);
-		comm->reg_base = devm_ioremap_resource(&vg->pdev->dev, mem_rc);
+		comm->reg_base = devm_platform_ioremap_resource(vg->pdev, 0);
 		if (IS_ERR(comm->reg_base))
 			return PTR_ERR(comm->reg_base);
 	}