[23/30] ext2: Use kmemdup rather than duplicating its implementation
diff mbox series

Message ID 20190703131727.25735-1-huangfq.daxian@gmail.com
State New
Headers show
Series
  • Untitled series #117567
Related show

Commit Message

Fuqian Huang July 3, 2019, 1:17 p.m. UTC
kmemdup is introduced to duplicate a region of memory in a neat way.
Rather than kmalloc/kzalloc + memset, which the programmer needs to
write the size twice (sometimes lead to mistakes), kmemdup improves
readability, leads to smaller code and also reduce the chances of mistakes.
Suggestion to use kmemdup rather than using kmalloc/kzalloc + memset.

Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
---
 fs/ext2/xattr.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Jan Kara July 3, 2019, 2:24 p.m. UTC | #1
On Wed 03-07-19 21:17:27, Fuqian Huang wrote:
> kmemdup is introduced to duplicate a region of memory in a neat way.
> Rather than kmalloc/kzalloc + memset, which the programmer needs to
> write the size twice (sometimes lead to mistakes), kmemdup improves
> readability, leads to smaller code and also reduce the chances of mistakes.
> Suggestion to use kmemdup rather than using kmalloc/kzalloc + memset.
> 
> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>

Thanks. Added to my tree.

								Honza

> ---
>  fs/ext2/xattr.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/ext2/xattr.c b/fs/ext2/xattr.c
> index 1e33e0ac8cf1..a9c641cd5484 100644
> --- a/fs/ext2/xattr.c
> +++ b/fs/ext2/xattr.c
> @@ -506,11 +506,10 @@ bad_block:		ext2_error(sb, "ext2_xattr_set",
>  
>  			unlock_buffer(bh);
>  			ea_bdebug(bh, "cloning");
> -			header = kmalloc(bh->b_size, GFP_KERNEL);
> +			header = kmemdup(HDR(bh), bh->b_size, GFP_KERNEL);
>  			error = -ENOMEM;
>  			if (header == NULL)
>  				goto cleanup;
> -			memcpy(header, HDR(bh), bh->b_size);
>  			header->h_refcount = cpu_to_le32(1);
>  
>  			offset = (char *)here - bh->b_data;
> -- 
> 2.11.0
> 
>

Patch
diff mbox series

diff --git a/fs/ext2/xattr.c b/fs/ext2/xattr.c
index 1e33e0ac8cf1..a9c641cd5484 100644
--- a/fs/ext2/xattr.c
+++ b/fs/ext2/xattr.c
@@ -506,11 +506,10 @@  bad_block:		ext2_error(sb, "ext2_xattr_set",
 
 			unlock_buffer(bh);
 			ea_bdebug(bh, "cloning");
-			header = kmalloc(bh->b_size, GFP_KERNEL);
+			header = kmemdup(HDR(bh), bh->b_size, GFP_KERNEL);
 			error = -ENOMEM;
 			if (header == NULL)
 				goto cleanup;
-			memcpy(header, HDR(bh), bh->b_size);
 			header->h_refcount = cpu_to_le32(1);
 
 			offset = (char *)here - bh->b_data;