Patchwork [-next] sctp: fix missing label when PROC_FS=n

login
register
mail settings
Submitter Randy Dunlap
Date Nov. 27, 2008, 8:18 p.m.
Message ID <20081127121824.5b3515c9.randy.dunlap@oracle.com>
Download mbox | patch
Permalink /patch/11260/
State Accepted
Delegated to: David Miller
Headers show

Comments

Randy Dunlap - Nov. 27, 2008, 8:18 p.m.
From: Randy Dunlap <randy.dunlap@oracle.com>

Fix missing label when CONFIG_PROC_FS=n:

net/sctp/protocol.c: In function 'sctp_proc_init':
net/sctp/protocol.c:106: error: label 'out_nomem' used but not defined
make[3]: *** [net/sctp/protocol.o] Error 1

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 net/sctp/protocol.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Nov. 27, 2008, 11:31 p.m.
From: Randy Dunlap <randy.dunlap@oracle.com>
Date: Thu, 27 Nov 2008 12:18:24 -0800

> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Fix missing label when CONFIG_PROC_FS=n:
> 
> net/sctp/protocol.c: In function 'sctp_proc_init':
> net/sctp/protocol.c:106: error: label 'out_nomem' used but not defined
> make[3]: *** [net/sctp/protocol.o] Error 1
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>

Applied, thanks a lot Randy.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- linux-next-20081127.orig/net/sctp/protocol.c
+++ linux-next-20081127/net/sctp/protocol.c
@@ -139,11 +139,12 @@  out_snmp_proc_init:
 	}
 out_free_percpu:
 	percpu_counter_destroy(&sctp_sockets_allocated);
-out_nomem:
-	return -ENOMEM;
 #else
 	return 0;
 #endif /* CONFIG_PROC_FS */
+
+out_nomem:
+	return -ENOMEM;
 }
 
 /* Clean up the proc fs entry for the SCTP protocol.