[V2,2/2] HE: mcs size is always a minimum of 4 bytes
diff mbox series

Message ID 20190701132709.18811-2-john@phrozen.org
State Accepted
Headers show
Series
  • [V2,1/2] HE: fix ieee80211_he_capabilities size
Related show

Commit Message

John Crispin July 1, 2019, 1:27 p.m. UTC
The MCS set always has a minimal size of 4 bytes. Without this change HE20
failed to work.

Signed-off-by: John Crispin <john@phrozen.org>
---
 src/ap/ieee802_11_he.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Jouni Malinen Aug. 11, 2019, 3:25 p.m. UTC | #1
On Mon, Jul 01, 2019 at 03:27:09PM +0200, John Crispin wrote:
> The MCS set always has a minimal size of 4 bytes. Without this change HE20
> failed to work.

Thanks, applied.

Patch
diff mbox series

diff --git a/src/ap/ieee802_11_he.c b/src/ap/ieee802_11_he.c
index 344a23347..9c3fb5929 100644
--- a/src/ap/ieee802_11_he.c
+++ b/src/ap/ieee802_11_he.c
@@ -79,7 +79,7 @@  u8 * hostapd_eid_he_capab(struct hostapd_data *hapd, u8 *eid,
 	struct hostapd_hw_modes *mode = hapd->iface->current_mode;
 	u8 he_oper_chwidth = ~HE_PHYCAP_CHANNEL_WIDTH_MASK;
 	u8 *pos = eid;
-	u8 ie_size = 0, mcs_nss_size = 0, ppet_size = 0;
+	u8 ie_size = 0, mcs_nss_size = 4, ppet_size = 0;
 
 	if (!mode)
 		return eid;
@@ -102,7 +102,6 @@  u8 * hostapd_eid_he_capab(struct hostapd_data *hapd, u8 *eid,
 	case CHANWIDTH_USE_HT:
 		he_oper_chwidth |= HE_PHYCAP_CHANNEL_WIDTH_SET_40MHZ_IN_2G |
 			HE_PHYCAP_CHANNEL_WIDTH_SET_40MHZ_80MHZ_IN_5G;
-		mcs_nss_size += 4;
 		break;
 	}