| Message ID | 20190701093034.18873-2-eric.auger@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | ARM SMMUv3: Fix spurious notification errors and stall with vfio-pci | expand |
On 7/1/19 11:30 AM, Eric Auger wrote: > memory_region_iommu_replay_all is not used. Remove it. > > Signed-off-by: Eric Auger <eric.auger@redhat.com> > Reported-by: Peter Maydell <peter.maydell@linaro.org> > --- > include/exec/memory.h | 10 ---------- > memory.c | 9 --------- > 2 files changed, 19 deletions(-) > > diff --git a/include/exec/memory.h b/include/exec/memory.h > index e6140e8a04..bdd76653a8 100644 > --- a/include/exec/memory.h > +++ b/include/exec/memory.h > @@ -1076,16 +1076,6 @@ void memory_region_register_iommu_notifier(MemoryRegion *mr, > */ > void memory_region_iommu_replay(IOMMUMemoryRegion *iommu_mr, IOMMUNotifier *n); > > -/** > - * memory_region_iommu_replay_all: replay existing IOMMU translations > - * to all the notifiers registered. > - * > - * Note: this is not related to record-and-replay functionality. > - * > - * @iommu_mr: the memory region to observe > - */ > -void memory_region_iommu_replay_all(IOMMUMemoryRegion *iommu_mr); > - > /** > * memory_region_unregister_iommu_notifier: unregister a notifier for > * changes to IOMMU translation entries. > diff --git a/memory.c b/memory.c > index 0a089a73ae..290a1493ef 100644 > --- a/memory.c > +++ b/memory.c > @@ -1910,15 +1910,6 @@ void memory_region_iommu_replay(IOMMUMemoryRegion *iommu_mr, IOMMUNotifier *n) > } > } > > -void memory_region_iommu_replay_all(IOMMUMemoryRegion *iommu_mr) > -{ > - IOMMUNotifier *notifier; > - > - IOMMU_NOTIFIER_FOREACH(notifier, iommu_mr) { > - memory_region_iommu_replay(iommu_mr, notifier); > - } > -} > - > void memory_region_unregister_iommu_notifier(MemoryRegion *mr, > IOMMUNotifier *n) > { > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
On Mon, Jul 01, 2019 at 11:30:29AM +0200, Eric Auger wrote: > memory_region_iommu_replay_all is not used. Remove it. > > Signed-off-by: Eric Auger <eric.auger@redhat.com> > Reported-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Peter Xu <peterx@redhat.com>
diff --git a/include/exec/memory.h b/include/exec/memory.h index e6140e8a04..bdd76653a8 100644 --- a/include/exec/memory.h +++ b/include/exec/memory.h @@ -1076,16 +1076,6 @@ void memory_region_register_iommu_notifier(MemoryRegion *mr, */ void memory_region_iommu_replay(IOMMUMemoryRegion *iommu_mr, IOMMUNotifier *n); -/** - * memory_region_iommu_replay_all: replay existing IOMMU translations - * to all the notifiers registered. - * - * Note: this is not related to record-and-replay functionality. - * - * @iommu_mr: the memory region to observe - */ -void memory_region_iommu_replay_all(IOMMUMemoryRegion *iommu_mr); - /** * memory_region_unregister_iommu_notifier: unregister a notifier for * changes to IOMMU translation entries. diff --git a/memory.c b/memory.c index 0a089a73ae..290a1493ef 100644 --- a/memory.c +++ b/memory.c @@ -1910,15 +1910,6 @@ void memory_region_iommu_replay(IOMMUMemoryRegion *iommu_mr, IOMMUNotifier *n) } } -void memory_region_iommu_replay_all(IOMMUMemoryRegion *iommu_mr) -{ - IOMMUNotifier *notifier; - - IOMMU_NOTIFIER_FOREACH(notifier, iommu_mr) { - memory_region_iommu_replay(iommu_mr, notifier); - } -} - void memory_region_unregister_iommu_notifier(MemoryRegion *mr, IOMMUNotifier *n) {
memory_region_iommu_replay_all is not used. Remove it. Signed-off-by: Eric Auger <eric.auger@redhat.com> Reported-by: Peter Maydell <peter.maydell@linaro.org> --- include/exec/memory.h | 10 ---------- memory.c | 9 --------- 2 files changed, 19 deletions(-)