[U-Boot,04/10] microblaze: Add netconsole support

Submitted by Michal Simek on Aug. 31, 2011, 8:35 a.m.

Details

Message ID 1314779721-1113-5-git-send-email-monstr@monstr.eu
State Changes Requested
Headers show

Commit Message

Michal Simek Aug. 31, 2011, 8:35 a.m.
Signed-off-by: Michal Simek <monstr@monstr.eu>
---
 arch/microblaze/lib/board.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

Comments

Mike Frysinger Aug. 31, 2011, 7:19 p.m.
On Wednesday, August 31, 2011 04:35:15 Michal Simek wrote:
> --- a/arch/microblaze/lib/board.c
> +++ b/arch/microblaze/lib/board.c
> @@ -167,6 +167,12 @@ void board_init (void)
>  	/* Initialize stdio devices */
>  	stdio_init ();
> 
> +	/* Initialize the jump table for applications */
> +	jumptable_init ();
> +
> +	/* Initialize the console (after the relocation and devices init) */
> +	console_init_r ();
> +
>  	if ((s = getenv ("loadaddr")) != NULL) {
>  		load_addr = simple_strtoul (s, NULL, 16);
>  	}

your summary doesnt seem to match what you're changing.  the two things you're 
doing here should always be done regardless of netconsole.
-mike
Michal Simek Sept. 1, 2011, 1:04 p.m.
Mike Frysinger wrote:
> On Wednesday, August 31, 2011 04:35:15 Michal Simek wrote:
>> --- a/arch/microblaze/lib/board.c
>> +++ b/arch/microblaze/lib/board.c
>> @@ -167,6 +167,12 @@ void board_init (void)
>>  	/* Initialize stdio devices */
>>  	stdio_init ();
>>
>> +	/* Initialize the jump table for applications */
>> +	jumptable_init ();
>> +
>> +	/* Initialize the console (after the relocation and devices init) */
>> +	console_init_r ();
>> +
>>  	if ((s = getenv ("loadaddr")) != NULL) {
>>  		load_addr = simple_strtoul (s, NULL, 16);
>>  	}
> 
> your summary doesnt seem to match what you're changing.  the two things you're 
> doing here should always be done regardless of netconsole.

It is really old patch where the point was to get netconsole work.
It is just initialize jumptable and setup correct console.

Fixed.

Thanks,
Michal
Wolfgang Denk Sept. 7, 2011, 9:02 p.m.
Dear Michal Simek,

In message <1314779721-1113-5-git-send-email-monstr@monstr.eu> you wrote:
> Signed-off-by: Michal Simek <monstr@monstr.eu>
> ---
>  arch/microblaze/lib/board.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/microblaze/lib/board.c b/arch/microblaze/lib/board.c
> index ab1cbab..e8f4c5b 100644
> --- a/arch/microblaze/lib/board.c
> +++ b/arch/microblaze/lib/board.c
> @@ -167,6 +167,12 @@ void board_init (void)
>  	/* Initialize stdio devices */
>  	stdio_init ();
>  
> +	/* Initialize the jump table for applications */
> +	jumptable_init ();
> +
> +	/* Initialize the console (after the relocation and devices init) */
> +	console_init_r ();

2 x WARNING: space prohibited between function name and open
parenthesis '('



Stop review here.  Will you please run your patches through ckeckpatch
_before_ submitting?  Thanks.

Best regards,

Wolfgang Denk

Patch hide | download patch | download mbox

diff --git a/arch/microblaze/lib/board.c b/arch/microblaze/lib/board.c
index ab1cbab..e8f4c5b 100644
--- a/arch/microblaze/lib/board.c
+++ b/arch/microblaze/lib/board.c
@@ -167,6 +167,12 @@  void board_init (void)
 	/* Initialize stdio devices */
 	stdio_init ();
 
+	/* Initialize the jump table for applications */
+	jumptable_init ();
+
+	/* Initialize the console (after the relocation and devices init) */
+	console_init_r ();
+
 	if ((s = getenv ("loadaddr")) != NULL) {
 		load_addr = simple_strtoul (s, NULL, 16);
 	}