Message ID | 1561695286-19265-1-git-send-email-liaoweixiong@allwinnertech.com |
---|---|
State | Accepted |
Headers | show |
Series | [v3] mtd: spinand: read return badly if the last page has bitflips | expand |
On Fri, 2019-06-28 at 04:14:46 UTC, liaoweixiong wrote: > In case of the last page containing bitflips (ret > 0), > spinand_mtd_read() will return that number of bitflips for the last > page. But to me it looks like it should instead return max_bitflips like > it does when the last page read returns with 0. > > Signed-off-by: Weixiong Liao <liaoweixiong@allwinnertech.com> > Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> > Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de> > Cc: stable@vger.kernel.org > Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI NANDs") Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Miquel
diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c index 556bfdb..6b9388d 100644 --- a/drivers/mtd/nand/spi/core.c +++ b/drivers/mtd/nand/spi/core.c @@ -511,12 +511,12 @@ static int spinand_mtd_read(struct mtd_info *mtd, loff_t from, if (ret == -EBADMSG) { ecc_failed = true; mtd->ecc_stats.failed++; - ret = 0; } else { mtd->ecc_stats.corrected += ret; max_bitflips = max_t(unsigned int, max_bitflips, ret); } + ret = 0; ops->retlen += iter.req.datalen; ops->oobretlen += iter.req.ooblen; }