From patchwork Tue Aug 30 15:04:41 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Stubbs X-Patchwork-Id: 112351 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id C409AB6F80 for ; Wed, 31 Aug 2011 01:05:09 +1000 (EST) Received: (qmail 15426 invoked by alias); 30 Aug 2011 15:05:06 -0000 Received: (qmail 15410 invoked by uid 22791); 30 Aug 2011 15:05:05 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: sourceware.org Received: from mail-ew0-f47.google.com (HELO mail-ew0-f47.google.com) (209.85.215.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 30 Aug 2011 15:04:48 +0000 Received: by ewy5 with SMTP id 5so3093040ewy.20 for ; Tue, 30 Aug 2011 08:04:47 -0700 (PDT) Received: by 10.216.174.80 with SMTP id w58mr850396wel.84.1314716686891; Tue, 30 Aug 2011 08:04:46 -0700 (PDT) Received: from [192.168.0.104] (cpc2-hawk4-0-0-cust828.aztw.cable.virginmedia.com [82.32.123.61]) by mx.google.com with ESMTPS id n20sm4699689wbh.33.2011.08.30.08.04.43 (version=SSLv3 cipher=OTHER); Tue, 30 Aug 2011 08:04:45 -0700 (PDT) Message-ID: <4E5CFC09.20906@codesourcery.com> Date: Tue, 30 Aug 2011 16:04:41 +0100 From: Andrew Stubbs User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20110812 Thunderbird/6.0 MIME-Version: 1.0 To: gcc-patches@gcc.gnu.org CC: Richard Earnshaw , patches@linaro.org Subject: Re: [PATCH][ARM] Thumb2 replicated constants References: <4DB013B7.4090504@codesourcery.com> <1304677098.5165.7.camel@e102346-lin.cambridge.arm.com> <4DC814EA.4070608@codesourcery.com> <4E576F60.2000100@codesourcery.com> <4E5CF46F.5090809@codesourcery.com> In-Reply-To: <4E5CF46F.5090809@codesourcery.com> Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On 30/08/11 15:32, Andrew Stubbs wrote: > On 26/08/11 11:03, Andrew Stubbs wrote: >> There was a bug I found in final testing, so this has been delayed >> somewhat. >> >> I've just committed this version. There are a few minor changes to the >> way negative/inverted constants are generated. > > Bernd found another bug whist testing for arm. Apparently there was a > bug that didn't show up in my thumb tests, although I have no clue why? > > Anyway, fixed thusly and committed as obvious (and urgent). And also there was an issue build with -Werror ... I'm not having much luck at the moment. :( Anyway, likewise fixed and committed as obvious. Andrew 2011-08-30 Andrew Stubbs gcc/ * config/arm/arm.c (optimal_immediate_sequence_1): Make b1, b2, b3 and b4 unsigned. --- a/gcc/config/arm/arm.c +++ b/gcc/config/arm/arm.c @@ -2624,7 +2624,7 @@ optimal_immediate_sequence_1 (enum rtx_code code, unsigned HOST_WIDE_INT val, do { int end; - int b1, b2, b3, b4; + unsigned int b1, b2, b3, b4; unsigned HOST_WIDE_INT result; int loc;