Patchwork [U-Boot] tools/env: use lib/crc32.c directly

login
register
mail settings
Submitter Andreas Bießmann
Date Aug. 30, 2011, 2:42 p.m.
Message ID <1314715349-29644-1-git-send-email-biessmann@corscience.de>
Download mbox | patch
Permalink /patch/112349/
State Superseded
Headers show

Comments

Andreas Bießmann - Aug. 30, 2011, 2:42 p.m.
Instead of linking the file into $(obj) tree use directly the source file.
This also prevents littered source tree if building not out-of-tree.

Signed-off-by: Andreas Bießmann <biessmann@corscience.de>
---
 tools/env/Makefile |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)
Mike Frysinger - Aug. 30, 2011, 3:08 p.m.
On Tuesday, August 30, 2011 10:42:29 Andreas Bießmann wrote:
> Instead of linking the file into $(obj) tree use directly the source file.
> This also prevents littered source tree if building not out-of-tree.

Acked-by: Mike Frysinger <vapier@gentoo.org>
-mike
Andreas Bießmann - Oct. 17, 2011, 9:08 a.m.
Am 30.08.2011 16:42, schrieb Andreas Bießmann:
> Instead of linking the file into $(obj) tree use directly the source file.
> This also prevents littered source tree if building not out-of-tree.
> 
> Signed-off-by: Andreas Bießmann <biessmann@corscience.de>

ping?

Patch

diff --git a/tools/env/Makefile b/tools/env/Makefile
index 2f7a59c..28b73da 100644
--- a/tools/env/Makefile
+++ b/tools/env/Makefile
@@ -23,7 +23,7 @@ 
 
 include $(TOPDIR)/config.mk
 
-HOSTSRCS := $(obj)crc32.c  fw_env.c  fw_env_main.c
+HOSTSRCS := $(SRCTREE)/lib/crc32.c  fw_env.c  fw_env_main.c
 HEADERS	:= fw_env.h
 
 # Compile for a hosted environment on the target
@@ -43,10 +43,7 @@  $(obj)fw_printenv:	$(HOSTSRCS) $(HEADERS)
 	$(HOSTCC) $(HOSTCFLAGS_NOPED) $(HOSTLDFLAGS) -o $@ $(HOSTSRCS)
 
 clean:
-	rm -f $(obj)fw_printenv $(obj)crc32.c
-
-$(obj)crc32.c:
-	ln -s $(src)../../lib/crc32.c $(obj)crc32.c
+	rm -f $(obj)fw_printenv
 
 #########################################################################