From patchwork Tue Aug 30 14:32:15 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Stubbs X-Patchwork-Id: 112339 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 75FADB70C7 for ; Wed, 31 Aug 2011 00:32:36 +1000 (EST) Received: (qmail 9403 invoked by alias); 30 Aug 2011 14:32:34 -0000 Received: (qmail 9393 invoked by uid 22791); 30 Aug 2011 14:32:33 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: sourceware.org Received: from mail-ww0-f41.google.com (HELO mail-ww0-f41.google.com) (74.125.82.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 30 Aug 2011 14:32:19 +0000 Received: by wwj26 with SMTP id 26so3573376wwj.2 for ; Tue, 30 Aug 2011 07:32:18 -0700 (PDT) Received: by 10.216.37.198 with SMTP id y48mr787056wea.100.1314714738618; Tue, 30 Aug 2011 07:32:18 -0700 (PDT) Received: from [192.168.0.104] (cpc2-hawk4-0-0-cust828.aztw.cable.virginmedia.com [82.32.123.61]) by mx.google.com with ESMTPS id eo6sm1810807wbb.65.2011.08.30.07.32.16 (version=SSLv3 cipher=OTHER); Tue, 30 Aug 2011 07:32:17 -0700 (PDT) Message-ID: <4E5CF46F.5090809@codesourcery.com> Date: Tue, 30 Aug 2011 15:32:15 +0100 From: Andrew Stubbs User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20110812 Thunderbird/6.0 MIME-Version: 1.0 To: gcc-patches@gcc.gnu.org CC: Richard Earnshaw , patches@linaro.org Subject: Re: [PATCH][ARM] Thumb2 replicated constants References: <4DB013B7.4090504@codesourcery.com> <1304677098.5165.7.camel@e102346-lin.cambridge.arm.com> <4DC814EA.4070608@codesourcery.com> <4E576F60.2000100@codesourcery.com> In-Reply-To: <4E576F60.2000100@codesourcery.com> Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On 26/08/11 11:03, Andrew Stubbs wrote: > There was a bug I found in final testing, so this has been delayed > somewhat. > > I've just committed this version. There are a few minor changes to the > way negative/inverted constants are generated. Bernd found another bug whist testing for arm. Apparently there was a bug that didn't show up in my thumb tests, although I have no clue why? Anyway, fixed thusly and committed as obvious (and urgent). Andrew 2011-08-30 Andrew Stubbs gcc/ * config/arm/arm.c (arm_gen_constant): Set can_negate correctly when code is SET. --- a/gcc/config/arm/arm.c +++ b/gcc/config/arm/arm.c @@ -3367,8 +3367,8 @@ arm_gen_constant (enum rtx_code code, enum machine_mode mode, rtx cond, if (code == SET) { + can_negate = can_invert; can_invert = 0; - can_negate = 1; code = PLUS; } else if (code == MINUS)