[1/9] tests: Fix rrm_beacon_req_passive_scan_vht false negative by using common finalizer rrm_beacon_req_passive_scan_vht fails with this message.
diff mbox series

Message ID 20190627054452.6547-1-masashi.honma@gmail.com
State Accepted
Headers show
Series
  • [1/9] tests: Fix rrm_beacon_req_passive_scan_vht false negative by using common finalizer rrm_beacon_req_passive_scan_vht fails with this message.
Related show

Commit Message

Masashi Honma June 27, 2019, 5:44 a.m. UTC
---------------
wlan0: Country code not reset back to 00: is FI
wlan0: Country code cleared back to 00
---------------

hostap commit 91b6eba7732354ed3dfe0aa9715dc4c0746e3336
'Move MAC address randomization enable/disable to helper functions'.

wireless-testing commit 66c112cbd1d44d05322bb4eef908c82a68adbb5e
tag: wt-2019-06-26.

This patch fixes the issue.

Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
---
 tests/hwsim/test_rrm.py | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Comments

Jouni Malinen July 30, 2019, 9:20 p.m. UTC | #1
On Thu, Jun 27, 2019 at 02:44:44PM +0900, Masashi Honma wrote:
> ---------------
> wlan0: Country code not reset back to 00: is FI
> wlan0: Country code cleared back to 00
> ---------------
> 
> hostap commit 91b6eba7732354ed3dfe0aa9715dc4c0746e3336
> 'Move MAC address randomization enable/disable to helper functions'.
> 
> wireless-testing commit 66c112cbd1d44d05322bb4eef908c82a68adbb5e
> tag: wt-2019-06-26.
> 
> This patch fixes the issue.

Thanks, applied all nine patches.

It's interesting that you are seeing this type of issues since I have
not seen them in a long while after the kernel changes went in for
fixing an issue in clearing the country code in some cases. Anyway,
these changes are nice cleanup, so they are useful even if they do not
fix anything visible in my setup.

Patch
diff mbox series

diff --git a/tests/hwsim/test_rrm.py b/tests/hwsim/test_rrm.py
index 81a94963c..c9c8d6103 100644
--- a/tests/hwsim/test_rrm.py
+++ b/tests/hwsim/test_rrm.py
@@ -1668,12 +1668,7 @@  def test_rrm_beacon_req_passive_scan_vht(dev, apdev):
                 raise HwsimSkip("80 MHz channel not supported in regulatory information")
         raise
     finally:
-        if hapd:
-            hapd.request("DISABLE")
-        dev[0].disconnect_and_stop_scan()
-        subprocess.call(['iw', 'reg', 'set', '00'])
-        dev[0].wait_event(["CTRL-EVENT-REGDOM-CHANGE"], timeout=0.5)
-        dev[0].flush_scan_cache()
+        clear_regdom(hapd, dev)
 
 def test_rrm_beacon_req_passive_scan_vht160(dev, apdev):
     """Beacon request - passive scan mode - VHT160"""