From patchwork Thu Nov 27 16:16:00 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick McHardy X-Patchwork-Id: 11230 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 5AA83DDDE7 for ; Fri, 28 Nov 2008 03:16:55 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753919AbYK0QQL (ORCPT ); Thu, 27 Nov 2008 11:16:11 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752222AbYK0QQK (ORCPT ); Thu, 27 Nov 2008 11:16:10 -0500 Received: from stinky.trash.net ([213.144.137.162]:53440 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752779AbYK0QQD (ORCPT ); Thu, 27 Nov 2008 11:16:03 -0500 Received: from [192.168.0.100] (unknown [78.42.204.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by stinky.trash.net (Postfix) with ESMTP id B85209489E; Thu, 27 Nov 2008 17:16:00 +0100 (MET) Message-ID: <492EC7C0.4040009@trash.net> Date: Thu, 27 Nov 2008 17:16:00 +0100 From: Patrick McHardy User-Agent: Mozilla-Thunderbird 2.0.0.17 (X11/20081018) MIME-Version: 1.0 To: davem@davemloft.net CC: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org Subject: Re: netfilter 00/29: Netfilter Update References: <20081127161503.13891.62766.sendpatchset@x2.localnet> In-Reply-To: <20081127161503.13891.62766.sendpatchset@x2.localnet> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Patrick McHardy wrote: > There's a trivial merge conflict in net/netfilter/nf_conntrack_netlink.c, > so the patches won't apply directly. Please pull from > > git://git.kernel.org/pub/scm/linux/kernel/git/kaber/nf-next-2.6.git And for reference, this is what I did to resolve the conflict: commit dbfaaa37cdfb579e317e2498eb2fc634be178761 Merge: 5b9ab2e... d6e8cc6... Author: Patrick McHardy Date: Thu Nov 27 16:28:34 2008 +0100 Merge branch 'master' of /home/kaber/src/nf/nf-next-2.6 Conflicts: net/netfilter/nf_conntrack_netlink.c diff --cc net/netfilter/nf_conntrack_netlink.c index 5f4a651,ccc5ef1..a0c9bc4 --- a/net/netfilter/nf_conntrack_netlink.c +++ b/net/netfilter/nf_conntrack_netlink.c @@@ -1087,10 -1131,9 +1131,9 @@@ ctnetlink_create_conntrack(struct nlatt { struct nf_conn *ct; int err = -EINVAL; - struct nf_conn_help *help; struct nf_conntrack_helper *helper; - ct = nf_conntrack_alloc(&init_net, otuple, rtuple, GFP_KERNEL); + ct = nf_conntrack_alloc(&init_net, otuple, rtuple, GFP_ATOMIC); if (ct == NULL || IS_ERR(ct)) return -ENOMEM; @@@ -1209,17 -1294,18 +1294,19 @@@ ctnetlink_new_conntrack(struct sock *ct goto out_unlock; } master_ct = nf_ct_tuplehash_to_ctrack(master_h); - atomic_inc(&master_ct->ct_general.use); + nf_conntrack_get(&master_ct->ct_general); } - spin_unlock_bh(&nf_conntrack_lock); err = -ENOENT; if (nlh->nlmsg_flags & NLM_F_CREATE) err = ctnetlink_create_conntrack(cda, &otuple, &rtuple, - master_ct); + master_ct, + NETLINK_CB(skb).pid, + nlmsg_report(nlh)); + spin_unlock_bh(&nf_conntrack_lock); + if (err < 0 && master_ct) nf_ct_put(master_ct);