| Message ID | 20190626140412.101607-1-giulio.benetti@micronovasrl.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/2] package/qt5/qt5base: drop wrong optimization flag | expand |
On Wed, 26 Jun 2019 16:04:11 +0200 Giulio Benetti <giulio.benetti@micronovasrl.com> wrote: > In qmake.conf.in has been left 'QMAKE_CXXFLAGS_RELEASE += -O3' but this > leads to not use Buildroot CXXFLAGS when building in release > mode(without debugging symbols). So let's remove it to let Qt5 to follow > Buildroot optimization flags like other packages do. > > Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com> > --- > package/qt5/qt5base/qmake.conf.in | 1 - > 1 file changed, 1 deletion(-) Applied to master, thanks. Thomas
>>>>> "Giulio" == Giulio Benetti <giulio.benetti@micronovasrl.com> writes: > In qmake.conf.in has been left 'QMAKE_CXXFLAGS_RELEASE += -O3' but this > leads to not use Buildroot CXXFLAGS when building in release > mode(without debugging symbols). So let's remove it to let Qt5 to follow > Buildroot optimization flags like other packages do. > Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com> Committed to 2019.02.x and 2019.05.x, thanks.
diff --git a/package/qt5/qt5base/qmake.conf.in b/package/qt5/qt5base/qmake.conf.in index f14527aa7f..26bee2cb39 100644 --- a/package/qt5/qt5base/qmake.conf.in +++ b/package/qt5/qt5base/qmake.conf.in @@ -15,7 +15,6 @@ QMAKE_CXX = $${CROSS_COMPILE}g++ # modifications to gcc-base.conf QMAKE_CFLAGS += $${BR_COMPILER_CFLAGS} QMAKE_CXXFLAGS += $${BR_COMPILER_CXXFLAGS} -QMAKE_CXXFLAGS_RELEASE += -O3 CONFIG += nostrip QMAKE_LIBS += -lrt -lpthread -ldl
In qmake.conf.in has been left 'QMAKE_CXXFLAGS_RELEASE += -O3' but this leads to not use Buildroot CXXFLAGS when building in release mode(without debugging symbols). So let's remove it to let Qt5 to follow Buildroot optimization flags like other packages do. Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com> --- package/qt5/qt5base/qmake.conf.in | 1 - 1 file changed, 1 deletion(-)