Patchwork fix the outdated comment in ext2_nfs_get_inode()

login
register
mail settings
Submitter Li Haifeng
Date Aug. 30, 2011, 11:46 a.m.
Message ID <CAFNq8R4Fbnuk_PnEKxCrNgnVA9w6H+LcSUNLWTqPcsiLquKLcA@mail.gmail.com>
Download mbox | patch
Permalink /patch/112263/
State Not Applicable
Headers show

Comments

Li Haifeng - Aug. 30, 2011, 11:46 a.m.
Signed-off-by: Li Haifeng <omycle@gmail.com>
---
 fs/ext2/super.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

    if (IS_ERR(inode))

Patch

diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index 1dd62ed..bda10cf 100644
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -327,10 +327,9 @@  static struct inode *ext2_nfs_get_inode(struct
super_block *sb,
    if (ino > le32_to_cpu(EXT2_SB(sb)->s_es->s_inodes_count))
        return ERR_PTR(-ESTALE);

-   /* iget isn't really right if the inode is currently unallocated!!
-    * ext2_read_inode currently does appropriate checks, but
-    * it might be "neater" to call ext2_get_inode first and check
-    * if the inode is valid.....
+   /*
+    * ext2_iget isn't really right if the inode is currently unallocated!!
+    * And it also does appropriate checks to handle the stale inode.
     */
    inode = ext2_iget(sb, ino);